-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OZ Improvements #847
Open
peersky
wants to merge
33
commits into
compound-finance:main
Choose a base branch
from
peersky:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
OZ Improvements #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kevincheng96 bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. One comment about a LOC that looks accidentally removed.
The secrets for the new env vars are now set up in the repo as well.
kevincheng96
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains improvements we did on OpenZeppelin side to use comet repo and particularly spider tool useful in monitoring stack CI/CD pipeline.
Changes consist of:
BASE_RPC_URL
environment variable forbase
networkSCROLL_RPC_URL
environment variable forscroll
networkSCROLLSCAN_KEY
instead ofETHERSCAN_KEY
pullFirstInternalTransactionForContract
Merging this PR implies that maintainers must agree to update env variables in repository:
BASE_RPC_URL
SCROLL_RPC_URL
SCROLLSCAN_KEY
Motivation
<NETWORK>_RPC_URL
allows us easier integrateIt resolves:
It surpasses: