New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pricefeeds for rsETH and weETH on Mainnet WETH market #878

Merged

torreyatcitty merged 13 commits into compound-finance:main from woof-software:woof-software/update-pricefeeds-for-rseth-and-weeth-on-mainnet-weth

Aug 16, 2024

Contributor

MishaShWoof commented Jul 1, 2024

No description provided.

MishaShWoof and others added 10 commits

July 1, 2024 13:38


          feat: new pricefeeds

51e63e5


          fix: rename

2c33985


          feat: add migration

cd5236c


          fix: fix migration

0807aea


          fix: add description

5e4bd91


          fix: post audit fixes

f242649


          fix: add sanity checks

563f2ba


          feat: add force deploy, because rsETH and weETH already exist, but we…

ada2986

… need to update them to new ones


          merge main

4f72982


          feat: add ezETH part as it was queued, but not executed; it will allo…

5974cff

…w to pass all the scenarios to not waiting till ezETH PR merging into main branch

Contributor

dmitriy-woof-software commented Aug 5, 2024

To merge after conflicts resolve

MishaShWoof added 3 commits

August 8, 2024 16:13


          Merge branch 'main' of github.com:woof-software/comet into woof-softw…

58076fd

…are/update-pricefeeds-for-rseth-and-weeth-on-mainnet-weth

fix

a79f38c


          fix: manually set enacted as true

bcb8732

Contributor

dmitriy-woof-software commented Aug 15, 2024 •

edited

Loading

Proposal - https://compound.finance/governance/proposals/277

torreyatcitty approved these changes

View reviewed changes

Contributor

torreyatcitty left a comment

LGTM

github-advanced-security bot found potential problems

View reviewed changes

contracts/pricefeeds/RateBasedScalingPriceFeed.sol

Comment on lines +41 to +54

+                  constructor(address underlyingPriceFeed_, uint8 decimals_, uint8 underlyingDecimals_, string memory description_) {
+                      underlyingPriceFeed = underlyingPriceFeed_;
+                      if (decimals_ > 18) revert BadDecimals();
+                      decimals = decimals_;
+                      description = description_;
+                      uint8 priceFeedDecimals = underlyingDecimals_;
+                      // Note: Solidity does not allow setting immutables in if/else statements
+                      shouldUpscale = priceFeedDecimals < decimals_ ? true : false;
+                      rescaleFactor = (shouldUpscale
+                          ? signed256(10 ** (decimals_ - priceFeedDecimals))
+                          : signed256(10 ** (priceFeedDecimals - decimals_))
+                      );
+                  }

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning

There're no sanity checks for the constructor argument description_.

contracts/pricefeeds/RateBasedScalingPriceFeed.sol

Comment on lines +41 to +54

+                  constructor(address underlyingPriceFeed_, uint8 decimals_, uint8 underlyingDecimals_, string memory description_) {
+                      underlyingPriceFeed = underlyingPriceFeed_;
+                      if (decimals_ > 18) revert BadDecimals();
+                      decimals = decimals_;
+                      description = description_;
+                      uint8 priceFeedDecimals = underlyingDecimals_;
+                      // Note: Solidity does not allow setting immutables in if/else statements
+                      shouldUpscale = priceFeedDecimals < decimals_ ? true : false;
+                      rescaleFactor = (shouldUpscale
+                          ? signed256(10 ** (decimals_ - priceFeedDecimals))
+                          : signed256(10 ** (priceFeedDecimals - decimals_))
+                      );
+                  }

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning

There're no sanity checks for the constructor argument underlyingDecimals_.

contracts/pricefeeds/RateBasedScalingPriceFeed.sol

Comment on lines +41 to +54

+                  constructor(address underlyingPriceFeed_, uint8 decimals_, uint8 underlyingDecimals_, string memory description_) {
+                      underlyingPriceFeed = underlyingPriceFeed_;
+                      if (decimals_ > 18) revert BadDecimals();
+                      decimals = decimals_;
+                      description = description_;
+                      uint8 priceFeedDecimals = underlyingDecimals_;
+                      // Note: Solidity does not allow setting immutables in if/else statements
+                      shouldUpscale = priceFeedDecimals < decimals_ ? true : false;
+                      rescaleFactor = (shouldUpscale
+                          ? signed256(10 ** (decimals_ - priceFeedDecimals))
+                          : signed256(10 ** (priceFeedDecimals - decimals_))
+                      );
+                  }

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning

There're no sanity checks for the constructor argument underlyingPriceFeed_.

contracts/pricefeeds/RateBasedScalingPriceFeed.sol

Comment on lines +41 to +54

+                  constructor(address underlyingPriceFeed_, uint8 decimals_, uint8 underlyingDecimals_, string memory description_) {
+                      underlyingPriceFeed = underlyingPriceFeed_;
+                      if (decimals_ > 18) revert BadDecimals();
+                      decimals = decimals_;
+                      description = description_;
+                      uint8 priceFeedDecimals = underlyingDecimals_;
+                      // Note: Solidity does not allow setting immutables in if/else statements
+                      shouldUpscale = priceFeedDecimals < decimals_ ? true : false;
+                      rescaleFactor = (shouldUpscale
+                          ? signed256(10 ** (decimals_ - priceFeedDecimals))
+                          : signed256(10 ** (priceFeedDecimals - decimals_))
+                      );
+                  }

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.non-payable-constructor Note

Consider making costructor payable to save gas.

contracts/pricefeeds/RateBasedScalingPriceFeed.sol

+                      uint256 updatedAt,
+                      uint80 answeredInRound
+                  ) {
+                      uint256 rate = IRateProvider(underlyingPriceFeed).getRate();

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.security.balancer-readonly-reentrancy-getrate Error

IRateProvider(underlyingPriceFeed).getRate() call on a Balancer pool is not protected from the read-only reentrancy.

contracts/pricefeeds/RsETHScalingPriceFeed.sol

Comment on lines +41 to +54

+                  constructor(address underlyingPriceFeed_, uint8 decimals_, string memory description_) {
+                      underlyingPriceFeed = underlyingPriceFeed_;
+                      if (decimals_ > 18) revert BadDecimals();
+                      decimals = decimals_;
+                      description = description_;
+                      uint8 underlyingPriceFeedDecimals = 18;
+                      // Note: Solidity does not allow setting immutables in if/else statements
+                      shouldUpscale = underlyingPriceFeedDecimals < decimals_ ? true : false;
+                      rescaleFactor = (shouldUpscale
+                          ? signed256(10 ** (decimals_ - underlyingPriceFeedDecimals))
+                          : signed256(10 ** (underlyingPriceFeedDecimals - decimals_))
+                      );
+                  }

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning

There're no sanity checks for the constructor argument description_.

contracts/pricefeeds/RsETHScalingPriceFeed.sol

Comment on lines +41 to +54

+                  constructor(address underlyingPriceFeed_, uint8 decimals_, string memory description_) {
+                      underlyingPriceFeed = underlyingPriceFeed_;
+                      if (decimals_ > 18) revert BadDecimals();
+                      decimals = decimals_;
+                      description = description_;
+                      uint8 underlyingPriceFeedDecimals = 18;
+                      // Note: Solidity does not allow setting immutables in if/else statements
+                      shouldUpscale = underlyingPriceFeedDecimals < decimals_ ? true : false;
+                      rescaleFactor = (shouldUpscale
+                          ? signed256(10 ** (decimals_ - underlyingPriceFeedDecimals))
+                          : signed256(10 ** (underlyingPriceFeedDecimals - decimals_))
+                      );
+                  }

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning

There're no sanity checks for the constructor argument underlyingPriceFeed_.

contracts/pricefeeds/RsETHScalingPriceFeed.sol

Comment on lines +41 to +54

+                  constructor(address underlyingPriceFeed_, uint8 decimals_, string memory description_) {
+                      underlyingPriceFeed = underlyingPriceFeed_;
+                      if (decimals_ > 18) revert BadDecimals();
+                      decimals = decimals_;
+                      description = description_;
+                      uint8 underlyingPriceFeedDecimals = 18;
+                      // Note: Solidity does not allow setting immutables in if/else statements
+                      shouldUpscale = underlyingPriceFeedDecimals < decimals_ ? true : false;
+                      rescaleFactor = (shouldUpscale
+                          ? signed256(10 ** (decimals_ - underlyingPriceFeedDecimals))
+                          : signed256(10 ** (underlyingPriceFeedDecimals - decimals_))
+                      );
+                  }

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.non-payable-constructor Note

Consider making costructor payable to save gas.

torreyatcitty merged commit b1ea9b0 into compound-finance:main

2 of 36 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet