-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wUSDM as collateral to USDT market on Mainnet #930
Add wUSDM as collateral to USDT market on Mainnet #930
Conversation
…ware/comet into woof-software/add-wusdm-to-mainnet-usdt
…ware/comet into woof-software/add-wusdm-to-mainnet-usdt
…are/add-wusdm-to-mainnet-usdt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
constructor(address rateProvider_, address underlyingPriceFeed_, uint8 decimals_, string memory description_) { | ||
rateProvider = rateProvider_; | ||
underlyingPriceFeed = underlyingPriceFeed_; | ||
rateProviderDecimals = IERC4626(rateProvider_).decimals(); | ||
underlyingDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals(); | ||
combinedScale = signed256(10 ** (rateProviderDecimals + underlyingDecimals)); | ||
description = description_; | ||
|
||
if (decimals_ > 18) revert BadDecimals(); | ||
decimals = decimals_; | ||
priceFeedScale = int256(10 ** decimals); | ||
} |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning
constructor(address rateProvider_, address underlyingPriceFeed_, uint8 decimals_, string memory description_) { | ||
rateProvider = rateProvider_; | ||
underlyingPriceFeed = underlyingPriceFeed_; | ||
rateProviderDecimals = IERC4626(rateProvider_).decimals(); | ||
underlyingDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals(); | ||
combinedScale = signed256(10 ** (rateProviderDecimals + underlyingDecimals)); | ||
description = description_; | ||
|
||
if (decimals_ > 18) revert BadDecimals(); | ||
decimals = decimals_; | ||
priceFeedScale = int256(10 ** decimals); | ||
} |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning
constructor(address rateProvider_, address underlyingPriceFeed_, uint8 decimals_, string memory description_) { | ||
rateProvider = rateProvider_; | ||
underlyingPriceFeed = underlyingPriceFeed_; | ||
rateProviderDecimals = IERC4626(rateProvider_).decimals(); | ||
underlyingDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals(); | ||
combinedScale = signed256(10 ** (rateProviderDecimals + underlyingDecimals)); | ||
description = description_; | ||
|
||
if (decimals_ > 18) revert BadDecimals(); | ||
decimals = decimals_; | ||
priceFeedScale = int256(10 ** decimals); | ||
} |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning
constructor(address rateProvider_, address underlyingPriceFeed_, uint8 decimals_, string memory description_) { | ||
rateProvider = rateProvider_; | ||
underlyingPriceFeed = underlyingPriceFeed_; | ||
rateProviderDecimals = IERC4626(rateProvider_).decimals(); | ||
underlyingDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals(); | ||
combinedScale = signed256(10 ** (rateProviderDecimals + underlyingDecimals)); | ||
description = description_; | ||
|
||
if (decimals_ > 18) revert BadDecimals(); | ||
decimals = decimals_; | ||
priceFeedScale = int256(10 ** decimals); | ||
} |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.non-payable-constructor Note
No description provided.