Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP-1989- upgrade compound-components pkg with wc v2 and ledger pkg diff #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ jobs:
env:
IPFS_AUTH: ${{ secrets.IPFS_AUTH }}
IPFS_HOST: ${{ secrets.IPFS_HOST }}
WALLET_CONNECT_PROJECT_ID: ${{ secrets.WALLET_CONNECT_PROJECT_ID }}

- name: Upload IPFS Release Artifact
uses: actions/upload-artifact@v1
Expand Down
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Each of the top level keys have the following functions:

## Getting Started

The Compound web3 front-end is written in [elm](http://elm-lang.org/) and was bootstrapped with [create elm app](https://github.com/halfzebra/create-elm-app). We strongly recommmend getting familiar with the Elm framework before jumping into the Compound source code.
The Compound web3 front-end is written in [elm](http://elm-lang.org/) and was bootstrapped with [create elm app](https://github.com/halfzebra/create-elm-app). We strongly recommend getting familiar with the Elm framework before jumping into the Compound source code.

To get started, first clone this repo:

Expand Down Expand Up @@ -125,6 +125,7 @@ To deploy a build to Infura IPFS:
IPFS_AUTH="PROJECT_ID:PROJECT_SECRET" \
IPFS_HOST="ipfs.infura.io" \
IPFS_PORT=5001 \
WALLET_CONNECT_PROJECT_ID="<WALLET_CONNECT_PROJECT_ID>"
yarn deploy-ipfs
```

Expand All @@ -133,6 +134,7 @@ Each of environment variables have the following functions:
* `IPFS_AUTH` - Basic authentication for header for using the Infura IPFS add endpoint. You can find more information [here](https://infura.io/docs/ipfs#section/Authentication).
* `IPFS_HOST` - IPFS Pinning service host.
* `IPFS_PORT` - IPFS Pinning service host port.
* `WALLET_CONNECT_PROJECT_ID` - Wallet Connect project id.

Note: The `deploy-ipfs` script has been tested and used with Infura IPFS. You may need a few changes to support alternative pinning services.

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"chalk": "^4.0.0",
"clean-webpack-plugin": "^3.0.0",
"cli-table": "0.3.1",
"compound-components": "https://github.com/compound-finance/compound-components.git#e1734102d56ffa14727f10435c68288d9f058a6d",
"compound-components": "https://github.com/compound-finance/compound-components.git#5be949127357848a7936cf9bb4cde82f586ba32a",
"compound-config": "https://github.com/compound-finance/compound-config.git#ff8e979ffcb286d09884163cc928688f213abe71",
"connect-history-api-fallback": "^1.5.0",
"core-js": "3",
Expand Down
3 changes: 2 additions & 1 deletion src/js/ports.js
Original file line number Diff line number Diff line change
Expand Up @@ -1650,7 +1650,8 @@ function subscribe(
blockNativeApiKeyInput
) {
const eth = makeEth(dataProviders, networkMap, networkAbiMap, configNameToAddressMappings, defaultNetwork);
connectedWalletPorts.subscribe(app, eth, globEthereum, networkMap, defaultNetwork);
const walletConnectProjectId = process.env['WALLET_CONNECT_PROJECT_ID'];
connectedWalletPorts.subscribe(app, eth, globEthereum, networkMap, defaultNetwork, walletConnectProjectId);

subscribeToConsole(app);
subscribeToSetBlockNativeNetwork(app, eth);
Expand Down
Loading