Update Foundry ir profiles (#224)

This PR attempts to standardize the `via-ir` settings used throughout
the repo. We set consistent configs for the `ir` Foundry profile in each
of the sub-projects. In CI and the deploy scripts, we also switch to
using the `ir` Foundry profile instead of relying on `via-ir`.

.github/workflows/gas-snapshot.yml

@@ -5,7 +5,7 @@ on:
   pull_request:
 
 env:
-  FOUNDRY_PROFILE: ci
+  FOUNDRY_PROFILE: ir
 
 jobs:
   snapshot-gas:
@@ -29,7 +29,7 @@ jobs:
         run: |
           set -euo pipefail
           # grep -E '^test'  -- skip over test results, just get diffs
-          forge snapshot --via-ir --diff \
+          forge snapshot --diff \
             | grep -E '^test'   \
             | tee .gas-snapshot.new
         env:

.github/workflows/lint.yml

@@ -5,7 +5,7 @@ on:
   pull_request:
 
 env:
-  FOUNDRY_PROFILE: ci
+  FOUNDRY_PROFILE: ir
 
 jobs:
   check:
@@ -30,7 +30,7 @@ jobs:
       - name: Run Forge build
         run: |
           forge --version
-          forge build --via-ir --sizes
+          forge build --sizes
         id: build
 
       - name: Run Forge Format

.github/workflows/test.yml

@@ -5,7 +5,7 @@ on:
   pull_request:
 
 env:
-  FOUNDRY_PROFILE: ci
+  FOUNDRY_PROFILE: ir
 
 jobs:
   check:
@@ -30,12 +30,12 @@ jobs:
       - name: Run Forge build
         run: |
           forge --version
-          forge build --via-ir --sizes
+          forge build --sizes
         id: build
 
       - name: Run Forge tests
         run: |
-          forge test --via-ir
+          forge test
         id: test
         env:
           MAINNET_RPC_URL: ${{ secrets.MAINNET_RPC_URL }}

foundry.toml

@@ -1,10 +1,13 @@
 [profile.default]
 solc = "0.8.27"
 evm_version = "cancun"
-
 libs = [ "./lib" ]
+bytecode_hash = "none"
+cbor_metadata = false
 
-# output intermediate representation
 [profile.ir]
-extra_output = ["ir"]
-extra_output_files = ["ir"]
+via_ir = true
+optimizer = true
+optimizer_runs = 100000000
+extra_output = [ "ir" ]
+extra_output_files = [ "ir" ]

script/deploy-code-jar.sh

@@ -20,7 +20,7 @@ else
   etherscan_args=""
 fi
 
-forge script --via-ir \
+FOUNDRY_PROFILE=ir forge script \
     $rpc_args \
     $wallet_args \
     $etherscan_args \

script/deploy-quark.sh

@@ -20,7 +20,7 @@ else
   etherscan_args=""
 fi
 
-forge script --via-ir \
+FOUNDRY_PROFILE=ir forge script \
     $rpc_args \
     $wallet_args \
     $etherscan_args \

script/prepare-release.sh

@@ -14,7 +14,7 @@ artifact_name="quark-out.${release_name}.zip"
 artifact_note="Compiled ABI"
 
 printf 'building full project...\n'
-forge build --via-ir
+FOUNDRY_PROFILE=ir forge build
 
 printf 'preparing release archive "%s"...\n' ${release_name}
 zip --recurse-paths "${artifact_name}" out/*

script/update-snapshot.sh

@@ -1,3 +1,3 @@
 #!/bin/bash
 
-forge snapshot --via-ir
+FOUNDRY_PROFILE=ir forge snapshot

src/codejar/foundry.toml

@@ -1,9 +1,14 @@
 [profile.default]
 solc = "0.8.27"
 evm_version = "cancun"
-
 libs = [ "../../lib" ]
-
 src = "src"
 out = "out"
 test = "../../test/codejar"
+
+[profile.ir]
+via_ir = true
+optimizer = true
+optimizer_runs = 100000000
+extra_output = [ "ir" ]
+extra_output_files = [ "ir" ]

src/quark-core-scripts/foundry.toml

@@ -1,9 +1,16 @@
 [profile.default]
 solc = "0.8.27"
 evm_version = "cancun"
-
 libs = [ "../../lib" ]
-
 src = "src"
 out = "out"
 test = "../../test/quark-core-scripts/"
+bytecode_hash = "none"
+cbor_metadata = false
+
+[profile.ir]
+via_ir = true
+optimizer = true
+optimizer_runs = 100000000
+extra_output = [ "ir" ]
+extra_output_files = [ "ir" ]

src/quark-core/foundry.toml

@@ -1,9 +1,16 @@
 [profile.default]
 solc = "0.8.27"
 evm_version = "cancun"
-
 libs = [ "../../lib" ]
-
 src = "src"
 out = "out"
 test = "../../test/quark-core"
+bytecode_hash = "none"
+cbor_metadata = false
+
+[profile.ir]
+via_ir = true
+optimizer = true
+optimizer_runs = 100000000
+extra_output = [ "ir" ]
+extra_output_files = [ "ir" ]

src/quark-factory/foundry.toml

@@ -1,9 +1,16 @@
 [profile.default]
 solc = "0.8.27"
 evm_version = "cancun"
-
 libs = [ "../../lib" ]
-
 src = "src"
 out = "out"
 test = "../../test/quark-factory/"
+bytecode_hash = "none"
+cbor_metadata = false
+
+[profile.ir]
+via_ir = true
+optimizer = true
+optimizer_runs = 100000000
+extra_output = [ "ir" ]
+extra_output_files = [ "ir" ]

src/quark-proxy/foundry.toml

@@ -1,19 +1,17 @@
 [profile.default]
 solc = "0.8.27"
 evm_version = "cancun"
-
 libs = [ "../../lib" ]
-
 src = "src"
 out = "out"
 test = "../../test/quark-proxy"
-
-# optimizer config
-optimizer = true
-optimizer_runs = 1
+cbor_metadata = false
 bytecode_hash = "none"
 
 [profile.ir]
 via_ir = true
+optimizer = true
+# We optimize for deployment cost over runtime gas efficiency
+optimizer_runs = 1
 extra_output = [ "ir" ]
 extra_output_files = [ "ir" ]