CIWEMB-569: Add Credit Note Tokens #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahrukh-compuco
force-pushed
the
CIWEMB-569-add-credit-note-tokens
branch
from
6fdf2d0 to
fba9d05
Compare
omarabuhussein
requested changes
Dec 12, 2023
There was a problem hiding this comment.
@shahrukh-compuco left a note, can you also squash the two commits in this PR into one, a commit like CIWEMB-569: Update code is vague and does not help or imply anything when you need to go back to look at the commit history later in the future, also check this document: https://compucorp.atlassian.net/wiki/spaces/SD/pages/1520173078/Git+Commits
shahrukh-compuco
force-pushed
the
CIWEMB-569-add-credit-note-tokens
branch
2 times, most recently
from
1adeda1 to
8dc2d2a
Compare
shahrukh-compuco
force-pushed
the
CIWEMB-569-add-credit-note-tokens
branch
from
8dc2d2a to
fe2900e
Compare
omarabuhussein
approved these changes
Dec 12, 2023
shahrukh-compuco
merged commit bcf6536
into
credit-note-changes-workstream
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pr adds credit note tokens while emailing the credit note.
Before
There were no credit note tokens to be used in subject or body of the email.
After