CIVIPLMMSR-302: Prevent sending multiple payment receipts #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After we separated the payment from contribution, the payment now separately sends a receipt to the user even though the contribution creation process will still send a receipt to the user, which will also consider whether the user checks the "Email Confirmation" box or not.
Before
The payment recording process sends a payment receipt to the user during payment creation.
After
The payment recording process no longer sends a payment receipt to the user during payment creation. Instead, the contribution recording process handles sending receipts to users, considering their preference for receiving email confirmations.
Technical Details
This happens because the default value of is_send_contribution_notification to the payment.create API is TRUE, we need to set it to FALSE and let the contribution recording process decide when to send email notifications to users.