Move types test to packages

.github/workflows/pull-request-validation.yml

@@ -133,7 +133,7 @@ jobs:
             --forceExit \
             --logHeapUsage \
             --runInBand \
-            --testPathPattern packages/\|__tests__/types/
+            --testPathPattern=/packages/\
         timeout-minutes: 10
 
       - if: always()

jest.config.js

@@ -99,7 +99,8 @@ module.exports = {
     '<rootDir>/__tests__/html/__jest__',
     '<rootDir>/__tests__/html/assets',
     '<rootDir>/__tests__/setup/',
-    '<rootDir>/__tests__/types/__typescript__',
+    '<rootDir>/packages/bundle/__tests__/types/__typescript__/',
+    '<rootDir>/packages/core/__tests__/types/__typescript__/',
     '<rootDir>/packages/directlinespeech/__tests__/utilities/',
     '<rootDir>/packages/playground/',
     '<rootDir>/samples/'

__tests__/types/__typescript__/fail-once/create-direct-line-invalid-bot-agent.tsx → packages/bundle/__tests__/types/__typescript__/fail-once/create-direct-line-invalid-bot-agent.tsx

@@ -1,4 +1,4 @@
-import { createDirectLine } from '../../../../packages/bundle';
+import { createDirectLine } from '../../../../lib/index';
 
 // "botAgent" is a forbidden option.
 createDirectLine({ botAgent: '123' });

__tests__/types/__typescript__/fail-once/create-direct-line-invalid-option.tsx → packages/bundle/__tests__/types/__typescript__/fail-once/create-direct-line-invalid-option.tsx

@@ -1,4 +1,4 @@
-import { createDirectLine } from '../../../../packages/bundle';
+import { createDirectLine } from '../../../../lib/index';
 
 // Object literal may only specify known properties, and 'invalid' does not exist in type 'Omit<CreateDirectLineOptions, "botAgent">'.
 createDirectLine({ invalid: true });

__tests__/types/__typescript__/fail-once/invalid-prop-type-dir.tsx → packages/bundle/__tests__/types/__typescript__/fail-once/invalid-prop-type-dir.tsx

@@ -1,4 +1,6 @@
-import ReactWebChat from '../../../../packages/bundle';
+import React from 'react';
+
+import ReactWebChat from '../../../../lib/index';
 
 // "dir" must be a string of "ltr' | 'rtl' | 'auto'.
 <ReactWebChat dir={123} directLine={undefined} />;

__tests__/types/__typescript__/fail-once/invalid-style-options-suggested-actions-stacked-overflow.ts → packages/bundle/__tests__/types/__typescript__/fail-once/invalid-style-options-suggested-actions-stacked-overflow.ts

@@ -1,4 +1,4 @@
-import { createStyleSet } from '../../../../packages/bundle';
+import { createStyleSet } from '../../../../lib/index';
 
 // Related to #4081.
 createStyleSet({ suggestedActionsStackedOverflow: 'string' });

__tests__/types/__typescript__/fail-once/invalid-type-for-use-style-options.tsx → packages/bundle/__tests__/types/__typescript__/fail-once/invalid-type-for-use-style-options.tsx

@@ -1,4 +1,4 @@
-import { hooks } from '../../../../packages/bundle';
+import { hooks } from '../../../../lib/index';
 
 const [styleOptions] = hooks.useStyleOptions();
 

packages/bundle/__tests__/types/__typescript__/fail-once/no-children-for-react-web-chat-in-minimal.tsx

@@ -0,0 +1,8 @@
+import React from 'react';
+
+import ReactWebChat from '../../../../lib/index-minimal';
+
+// <ReactWebChat> should not contains any children.
+<ReactWebChat directLine={undefined}>
+  <div>Hello, World</div>
+</ReactWebChat>;

__tests__/types/__typescript__/fail-once/no-children-for-react-web-chat-in-minimal.tsx → packages/bundle/__tests__/types/__typescript__/fail-once/no-children-for-react-web-chat.tmp.tsx

@@ -1,4 +1,6 @@
-import ReactWebChat from '../../../../packages/bundle/lib/index-minimal';
+import React from 'react';
+
+import ReactWebChat from '../../../../lib/index';
 
 // <ReactWebChat> should not contains any children.
 <ReactWebChat directLine={undefined}>

__tests__/types/__typescript__/fail-once/no-children-for-react-web-chat.tsx → packages/bundle/__tests__/types/__typescript__/fail-once/no-children-for-react-web-chat.tsx

@@ -1,4 +1,6 @@
-import ReactWebChat from '../../../../packages/bundle';
+import React from 'react';
+
+import ReactWebChat from '../../../../lib/index';
 
 // <ReactWebChat> should not contains any children.
 <ReactWebChat directLine={undefined}>

__tests__/types/__typescript__/fail-once/no-full-bundle-style-options-in-minimal-for-hooks.ts → packages/bundle/__tests__/types/__typescript__/fail-once/no-full-bundle-style-options-in-minimal-for-hooks.ts

@@ -1,4 +1,4 @@
-import { hooks } from '../../../../packages/bundle/lib/index-minimal';
+import { hooks } from '../../../../lib/index-minimal';
 
 const [styleOptions] = hooks.useStyleOptions();
 

__tests__/types/__typescript__/fail-once/no-full-bundle-style-options-in-minimal.ts → packages/bundle/__tests__/types/__typescript__/fail-once/no-full-bundle-style-options-in-minimal.ts

@@ -1,4 +1,4 @@
-import { createStyleSet } from '../../../../packages/bundle/lib/index-minimal';
+import { createStyleSet } from '../../../../lib/index-minimal';
 
 // "cardEmphasisBackgroundColor" is a style options only available in full bundle.
 createStyleSet({ cardEmphasisBackgroundColor: 'orange' });

packages/bundle/__tests__/types/__typescript__/pass/additional-style-options-in-full.ts

@@ -0,0 +1,3 @@
+import { createStyleSet } from '../../../../lib/index';
+
+createStyleSet({ cardEmphasisBackgroundColor: 'orange' });

__tests__/types/__typescript__/pass/composition-with-store.tsx → packages/bundle/__tests__/types/__typescript__/pass/composition-with-store.tsx

@@ -1,6 +1,7 @@
+import React from 'react';
 import ReactDOM from 'react-dom';
 
-import { Components, createStore } from '../../../../packages/bundle';
+import { Components, createStore } from '../../../../lib/index';
 
 const { BasicWebChat, Composer } = Components;
 

packages/bundle/__tests__/types/__typescript__/pass/correct-type-dir.tsx

@@ -0,0 +1,5 @@
+import React from 'react';
+
+import ReactWebChat from '../../../../lib/index';
+
+<ReactWebChat dir="ltr" directLine={undefined} />;

packages/bundle/__tests__/types/__typescript__/pass/import-component-send-text-box.tsx

@@ -0,0 +1,7 @@
+import React from 'react';
+
+import { Components } from '../../../../lib/index';
+
+const { SendTextBox } = Components;
+
+<SendTextBox />;

packages/bundle/__tests__/types/__typescript__/pass/import-create-direct-line.tsx

@@ -0,0 +1,3 @@
+import { createDirectLine } from '../../../../lib/index';
+
+createDirectLine({ token: 'faketoken' });

__tests__/types/__typescript__/pass/render-with-minimal-bundle.tsx → packages/bundle/__tests__/types/__typescript__/pass/render-with-minimal-bundle.tsx

@@ -1,6 +1,7 @@
+import React from 'react';
 import ReactDOM from 'react-dom';
 
-import ReactWebChat, { createDirectLine } from '../../../../packages/bundle/lib/index-minimal';
+import ReactWebChat, { createDirectLine } from '../../../../lib/index-minimal';
 
 const directLine = createDirectLine({ token: '...' });
 const styleOptions = { accent: 'black' };

__tests__/types/__typescript__/pass/render-with-store.tsx → packages/bundle/__tests__/types/__typescript__/pass/render-with-store.tsx

@@ -1,6 +1,7 @@
+import React from 'react';
 import ReactDOM from 'react-dom';
 
-import { Components, createStore } from '../../../../packages/bundle';
+import { Components, createStore } from '../../../../lib/index';
 
 const { Composer } = Components;
 

__tests__/types/__typescript__/pass/render-with-style-options.tsx → packages/bundle/__tests__/types/__typescript__/pass/render-with-style-options.tsx

@@ -1,6 +1,7 @@
+import React from 'react';
 import ReactDOM from 'react-dom';
 
-import ReactWebChat, { createDirectLine } from '../../../../packages/bundle';
+import ReactWebChat, { createDirectLine } from '../../../../lib/index';
 
 const directLine = createDirectLine({ token: '...' });
 const styleOptions = { accent: 'black', cardEmphasisBackgroundColor: 'orange' };

__tests__/types/__typescript__/pass/render-with-style-set.tsx → packages/bundle/__tests__/types/__typescript__/pass/render-with-style-set.tsx

@@ -1,6 +1,7 @@
+import React from 'react';
 import ReactDOM from 'react-dom';
 
-import ReactWebChat, { createDirectLine, createStyleSet } from '../../../../packages/bundle/lib/index-minimal';
+import ReactWebChat, { createDirectLine, createStyleSet } from '../../../../lib/index-minimal';
 
 const directLine = createDirectLine({ token: '...' });
 const styleOptions = { accent: 'black', cardEmphasisBackgroundColor: 'orange' };

__tests__/types/__typescript__/pass/render.tsx → packages/bundle/__tests__/types/__typescript__/pass/render.tsx

@@ -1,6 +1,7 @@
+import React from 'react';
 import ReactDOM from 'react-dom';
 
-import ReactWebChat, { createDirectLine } from '../../../../packages/bundle';
+import ReactWebChat, { createDirectLine } from '../../../../lib/index';
 
 const directLine = createDirectLine({ token: '...' });
 

__tests__/types/__typescript__/pass/use-style-options-with-full-bundle.ts → packages/bundle/__tests__/types/__typescript__/pass/use-style-options-with-full-bundle.ts

@@ -1,4 +1,4 @@
-import { hooks } from '../../../../packages/bundle';
+import { hooks } from '../../../../lib/index';
 
 const [styleOptions] = hooks.useStyleOptions();
 

__tests__/types/__typescript__/pass/valid-style-options-suggested-actions-stacked-overflow.ts → packages/bundle/__tests__/types/__typescript__/pass/valid-style-options-suggested-actions-stacked-overflow.ts

@@ -1,4 +1,4 @@
-import { createStyleSet } from '../../../../packages/bundle';
+import { createStyleSet } from '../../../../lib/index';
 
 // Related to #4081.
 createStyleSet({ suggestedActionsStackedOverflow: 'auto' });

__tests__/types/__typescript__/pass/direct-line-activity-from-bot.ts → packages/core/__tests__/types/__typescript__/pass/direct-line-activity-from-bot.ts

@@ -1,4 +1,4 @@
-import type { WebChatActivity } from '../../../../packages/core';
+import type { WebChatActivity } from '../../../../lib/index';
 
 // All activities from bot must be from server.
 const activity: WebChatActivity = {

__tests__/types/__typescript__/pass/direct-line-activity-from-user-send-failed.ts → packages/core/__tests__/types/__typescript__/pass/direct-line-activity-from-user-send-failed.ts

@@ -1,4 +1,4 @@
-import type { WebChatActivity } from '../../../../packages/core';
+import type { WebChatActivity } from '../../../../lib/index';
 
 // All activities that failed to send, are activities that never reach the server (a.k.a. activity-in-transit).
 const activity: WebChatActivity = {

__tests__/types/__typescript__/pass/direct-line-activity-from-user-sending.ts → packages/core/__tests__/types/__typescript__/pass/direct-line-activity-from-user-sending.ts

@@ -1,4 +1,4 @@
-import type { WebChatActivity } from '../../../../packages/core';
+import type { WebChatActivity } from '../../../../lib/index';
 
 // All activities that are sending, are activities that did not reach the server yet (a.k.a. activity-in-transit).
 const activity: WebChatActivity = {

__tests__/types/__typescript__/pass/direct-line-activity-from-user-sent.ts → packages/core/__tests__/types/__typescript__/pass/direct-line-activity-from-user-sent.ts

@@ -1,4 +1,4 @@
-import type { WebChatActivity } from '../../../../packages/core';
+import type { WebChatActivity } from '../../../../lib/index';
 
 // All activities which are "sent", must be from server.
 const activity: WebChatActivity = {

packages/core/__tests__/types/tsconfig.json

@@ -0,0 +1,5 @@
+{
+  "compilerOptions": {
+    "strict": true
+  }
+}

packages/core/__tests__/types/typescript.js

@@ -0,0 +1,96 @@
+const { join, relative } = require('path');
+const { readdir } = require('fs').promises;
+
+const ts = require('typescript');
+
+function compile(...filenames) {
+  const program = ts.createProgram(filenames, {
+    allowSyntheticDefaultImports: true,
+    jsx: 'react',
+    noEmit: true,
+    skipLibCheck: true,
+    strict: true
+  });
+
+  const emitResult = program.emit();
+  const allDiagnostics = ts.getPreEmitDiagnostics(program).concat(emitResult.diagnostics);
+  const errors = [];
+
+  allDiagnostics.forEach(diagnostic => {
+    if (diagnostic.file) {
+      const { line, character } = diagnostic.file.getLineAndCharacterOfPosition(diagnostic.start);
+      const message = ts.flattenDiagnosticMessageText(diagnostic.messageText, '\n');
+
+      errors.push(`${diagnostic.file.fileName} (${line + 1},${character + 1}): ${message}`);
+    } else {
+      errors.push(ts.flattenDiagnosticMessageText(diagnostic.messageText, '\n'));
+    }
+  });
+
+  return errors;
+}
+
+describe('compiling TypeScript files', () => {
+  describe('in /pass/ folder', () => {
+    let results;
+
+    beforeEach(async () => {
+      const path = join(__dirname, '__typescript__/pass/');
+      let files = [];
+
+      try {
+        files = await readdir(path);
+      } catch (error) {
+        if (error.code !== 'ENOENT') {
+          throw error;
+        }
+      }
+
+      results = {};
+
+      files.forEach(file => {
+        const fullPath = join(path, file);
+
+        results[relative(path, fullPath)] = { errors: compile(fullPath) };
+      });
+    });
+
+    test('should pass', () => {
+      for (const filename of Object.keys(results)) {
+        expect(results).toHaveProperty([filename, 'errors'], []);
+        expect(results).toHaveProperty([filename, 'errors', 'length'], 0);
+      }
+    });
+  });
+
+  describe('in /fail-once/ folder', () => {
+    let results;
+
+    beforeEach(async () => {
+      const path = join(__dirname, '__typescript__/fail-once/');
+      let files = [];
+
+      try {
+        files = await readdir(path);
+      } catch (error) {
+        if (error.code !== 'ENOENT') {
+          throw error;
+        }
+      }
+
+      results = {};
+
+      files.forEach(file => {
+        const fullPath = join(path, file);
+
+        results[relative(path, fullPath)] = { errors: compile(fullPath) };
+      });
+    });
+
+    test('should fail only once', () => {
+      for (const filename of Object.keys(results)) {
+        expect(results).toHaveProperty([filename, 'errors', 'length'], 1);
+      }
+    });
+  });
+});