add marisa/0.2.6 recipe

[tuduongquyet]

• Specify library name and version: marisa/0.2.6
• marisa is the dependency of libeb

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the conan-center hook activated.

[uilianries]

DO not create a patch for it, instead, add as regular file

[tuduongquyet]

Could you show me how to do that? Any ref.?

[uilianries]

Add as you did for other files in this PR:

git add CMakeLists.txt
git commit -s -m "Add Cmake file for marisa"
git push origin marisa/0.2.6

[prince-chrismc]

Why not use the upstream's build system? https://github.com/s-yata/marisa-trie#build-instructions we have some docs on this https://github.com/conan-io/conan-center-index/blob/master/docs/how_to_add_packages.md#autotools

Also there's a year old PR s-yata/marisa-trie#43 so usually I would suggestion making a PR to share your implementation but they are not very active

[uilianries]

Yes, @prince-chrismc approach is the better way.

[tuduongquyet]

Why not use the upstream's build system? https://github.com/s-yata/marisa-trie#build-instructions we have some docs on this https://github.com/conan-io/conan-center-index/blob/master/docs/how_to_add_packages.md#autotools

Also there's a year old PR s-yata/marisa-trie#43 so usually I would suggestion making a PR to share your implementation but they are not very active

The reason why I don't use upstream build system is:

• I want to add build support for Windows MSVC
• Since I keep facing issues like this when I tried to create recipes for C++ Project which use autotools as build system:
  • Add libstrophe/0.12.1 recipe #11840 kinda has the same issue,
  • Add Marisa Trie 0.2.6 #5863 has the same issue.
    --> So I tried to use CMake system for this project.

[prince-chrismc]

In that case the "Accepted" approach is something like https://github.com/conan-io/conan-center-index/blob/c4a7e6a366a1e600167da37f40be8cab13357358/recipes/giflib/5.2.x/CMakeLists.txt

There's some points in this CMake, like shared build, which are not required (CMake natively supports that option internal so you dont need to declare it) also there should not be any tests

[prince-chrismc]

There a more optimal way that we are trying to encourage https://github.com/conan-io/conan-center-index/blob/master/docs/reviewing.md#exporting-patches

[tuduongquyet]

Yes, I will fix as your suggestion

[prince-chrismc]

Why not use the upstream's build system? https://github.com/s-yata/marisa-trie#build-instructions we have some docs on this https://github.com/conan-io/conan-center-index/blob/master/docs/how_to_add_packages.md#autotools

Also there's a year old PR s-yata/marisa-trie#43 so usually I would suggestion making a PR to share your implementation but they are not very active

[prince-chrismc]

Upstream project does not have CMake targets

Suggested change

	self.cpp_info.names["cmake_find_package"] = "marisa"
	self.cpp_info.names["cmake_find_package_multi"] = "marisa"

[conan-center-bot]

All green in build 26 (72e93e84cbf492b4c627da8e6e910ed9a44bcc6e):

• marisa/0.2.6@:
  All packages built successfully! (All logs)

  🔸 Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
  This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
  See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11877/recipes/marisa/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11877/recipes/marisa/all/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-11877/recipes/marisa/all/conanfile.py", line 4, in <module>
      from conans import CMake
  ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

[danimtb]

i know it requires some more work, but as this has been open for a while and the recipe is a new one, I prefer to have it accepted than dropping it all the way