feat: modifiers in spec #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
DCM report❌ warning issues: 1 Full report: https://github.com/conceptadev/mix/runs/26769029694 |
tilucasoli
force-pushed
the
feat/modifiers-in-spec
branch
from
1c3a165
to
41cbb5b
Compare
tilucasoli
commented
Jun 28, 2024
packages/mix/lib/src/attributes/modifiers/widget_modifiers_util.dart
Outdated
Show resolved
Hide resolved
| @@ -50,28 +51,32 @@ class IconSpecWidget extends StatelessWidget { | |||
| this.semanticLabel, | |||
| super.key, | |||
| this.textDirection, | |||
| this.modifierOrder = const [], | |||
| this.orderOfModifiers = const [], | |||
| }); | |||
|
|
|||
| final IconData? icon; | |||
| final IconSpec? spec; | |||
There was a problem hiding this comment.
For the Widget spec, all of them follow the same basic structure, a spec attribute with some Spec and an attribute called orderOfModifiers. What if we create an abstract class SpecWidget?
|
@leoafarias do you think we should create a document for this migration now? |
github-actions
bot
added
documentation
github-actions
bot
added
documentation
github-actions
bot
added
documentation
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#313
Description
Add the ability to set modifiers in specs.
Changes
Spec;Specinstead ofAttribute;RenderModifiers;Review Checklist
Additional Information (optional)
I tried not to create breaking changes, let me know if you have any doubts about some modifications.