Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exception when there is no children on flex #345

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

leoafarias
Copy link
Member

Exception on flex widget when there are no children and it tries to add a gap.

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Impacted Packages

Please indicate which packages in our project are affected by these changes:

  • mix
  • mix_lint
  • mix_generator
  • documentation

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2024 5:33pm

@tilucasoli tilucasoli self-requested a review July 2, 2024 11:53
@@ -211,11 +212,11 @@ class FlexBox extends StyledWidget {
/// ```
class HBox extends FlexBox {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making a test for this specific use case?

@leoafarias leoafarias changed the title Exception when there is no children fix - Exception when there is no children on flex Jul 2, 2024
@leoafarias leoafarias changed the title fix - Exception when there is no children on flex fix: Exception when there is no children on flex Jul 2, 2024
@leoafarias leoafarias merged commit e19b99d into main Jul 2, 2024
5 of 6 checks passed
@leoafarias leoafarias deleted the fix/exception-no-children branch July 2, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants