Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Toast animation trigger #530

Merged
merged 3 commits into from
Nov 26, 2024
Merged

fix: Toast animation trigger #530

merged 3 commits into from
Nov 26, 2024

Conversation

tilucasoli
Copy link
Collaborator

Description

  • Everytime that toast need to rebuild the animation was being triggered, so this PR fix it. Additionally, I add some new methods

Changes

  • Fix the animation trigger
  • Add a scenario when the animation is equals to Duration.zero

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Additional Information (optional)

Is there any additional context or documentation that might be helpful for reviewers?

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 7:23pm

@github-actions github-actions bot added the remix label Nov 26, 2024
@tilucasoli tilucasoli changed the title fix: toast reload fix: Toast rerunning animation Nov 26, 2024
@tilucasoli tilucasoli merged commit 250b288 into main Nov 26, 2024
6 checks passed
@tilucasoli tilucasoli deleted the fix-toast-reload branch November 26, 2024 20:10
@tilucasoli tilucasoli changed the title fix: Toast rerunning animation fix: Toast animation trigger Nov 26, 2024
@github-actions github-actions bot added mix and removed remix labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant