Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize components implementation #19

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Conversation

tilucasoli
Copy link
Collaborator

Describe your changes

  • We normalize the widgets implementations
  • The main difference is the new RemixWidgetBuilder

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

class AvatarStyles extends StyleRecipe<AvatarStyles> {
const AvatarStyles({
class RemixAvatarStyles extends StyleRecipe<RemixAvatarStyles> {
const RemixAvatarStyles({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do RemixAvatarStyle like we talked about


@override
final BadgeStyles? style;
final RemixBadgeStyles? style;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here also RemixBadgeStyle

Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit 8609b24 into main Feb 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants