Feat/pool fees #10
Feat/pool fees #10
Conversation
There was a problem hiding this comment.
Hi @patrick-concero, There aren't many changes in the DexSwap as far as I can see, pls let me know if I'm not looking at the right files
| function getWrappedNative() internal view returns (address _wrappedAddress) { | ||
| uint256 chainId = block.chainid; | ||
|
|
||
| if (chainId == CHAIN_ID_AVALANCHE) { |
There was a problem hiding this comment.
Hi! @patrick-concero, why are we using CHAIN_IDs here if we already have chain selectors? Let's move the logic to chain selectors to have less constant variables and less things to keep in mind.
There was a problem hiding this comment.
Because chain selectors are related to bridge functionalities and are not sent through _swap functions. Also, the chainSelector sent through the swapAndBridge function it's related to destination, not source. It can't be used as we need to get a source wrapper in this case.
If I am missing something, please let me know.
Feat/pool fees
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Description
Concise description of proposed changes, We recommend using screenshots and videos for better description
Additional Information
Related Issues
Closes #{issue number}
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: