Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fetching specific versions of releases. #15

Merged
merged 2 commits into from
Aug 22, 2018

Conversation

dark5un
Copy link

@dark5un dark5un commented Aug 14, 2018

  • While adding this feature we realised that we could not run the tests because building with alpine:edge resulted with an error. So we included this fix as well.

This also addresses #14

cc @crsimmons

@vito
Copy link
Member

vito commented Aug 22, 2018

Hmm I'd rather not switch out the base image as part of this. Would you mind removing that from this PR? It looks like it's failing on the openssl package, which I also saw happening in another resource. I can just remove it from the list.

Also jfyi concourse/concourse#1707 will probably be the way to express this kind of thing in the future. I'll merge this for now though since we can always address it if/when we make this resource space-aware.

@crsimmons
Copy link
Member

@vito Thanks.

I've removed the base image change. Looking forward to spatial resources when they land.

@vito
Copy link
Member

vito commented Aug 22, 2018

thanks!

@vito vito merged commit b7d0e93 into concourse:master Aug 22, 2018
@vito vito modified the milestone: v4.1.0 Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants