-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
track base resource pipelines in reconfigure.yml #207
Conversation
cbbc6ed
to
e0f4a63
Compare
RESOURCES: | ||
run: | ||
path: pipelines/tasks/scripts/render-resource-pipeline-templates | ||
user: root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to explicitly tell that to run as root within the container? is it because bitnami/jsonnet
has a different user set by default that concourse doesn't detect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something wacky about that image, yeah: https://hub.docker.com/r/bitnami/jsonnet/dockerfile the USER 1001
doesn't have permission to read from the task input or write to the task output. Might be worth using a different image, I just liked the sales pitch.
pool | ||
datadog-event | ||
mock | ||
- put : prod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I got it right, I think we don't need any other inputs other than rendered_pipelines
🤔
- put : prod | |
- put: prod | |
inputs: [rendered_pipelines] |
not really a big deal though 😁 totally optional
(soon we'll be able to use detect
though 👀 concourse/concourse#4616)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hahaha I originally had it this way and opted for less code! Maybe it's worth just getting in the habit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niiice to see it in a pipeline! LGTM 😁
I just added a minor optional suggestion around explicitly setting inputs
to the put step
73d1519
to
02a60b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny change to make output more clear
5327605
to
0603875
Compare
Signed-off-by: Zoe Tian <[email protected]> Co-authored-by: Jamie Klassen <[email protected]>
Signed-off-by: Jamie Klassen <[email protected]>
Signed-off-by: Jamie Klassen <[email protected]>
Signed-off-by: Jamie Klassen <[email protected]> Co-authored-by: Alex Suraci <[email protected]>
0603875
to
00a6d47
Compare
contributes to concourse/prod#36