Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Port Name overrides on web-api-service #326

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enable Port Name overrides on web-api-service #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e44d396
add parameters for port names
ibrahimparvez2 Feb 4, 2023
cfb8ea7
add templating defaults
ibrahimparvez2 Feb 4, 2023
839b127
update readme
ibrahimparvez2 Feb 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ The following table lists the configurable parameters of the Concourse chart and
| `web.service.api.loadBalancerSourceRanges` | Concourse Web API Service Load Balancer Source IP ranges | `nil` |
| `web.service.api.tlsNodePort` | Sets the nodePort for api tls when using `NodePort` | `nil` |
| `web.service.api.type` | Concourse Web API service type | `ClusterIP` |
| `web.service.api.port.name` | Sets the port name for web service with `targetPort` `atc` | `atc` |
| `web.service.api.tlsPort.name` | Sets the port name for web service with `targetPort` `atc-tls` | `atc-tls` |
| `web.service.workerGateway.annotations` | Concourse Web workerGateway Service annotations | `nil` |
| `web.service.workerGateway.labels` | Additional concourse web workerGateway service labels | `nil` |
| `web.service.workerGateway.loadBalancerIP` | The IP to use when web.service.workerGateway.type is LoadBalancer | `nil` |
Expand Down
4 changes: 2 additions & 2 deletions templates/web-api-svc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ spec:
loadBalancerIP: {{ .Values.web.service.api.loadBalancerIP }}
{{- end }}
ports:
- name: atc
- name: ({ .Values.concourse.web.service.api.port.name }}
port: {{ .Values.concourse.web.bindPort }}
targetPort: atc
{{- if and (eq "NodePort" .Values.web.service.api.type) .Values.web.service.api.NodePort }}
nodePort: {{ .Values.web.service.api.NodePort}}
{{- end }}
{{- if .Values.concourse.web.tls.enabled }}
- name: atc-tls
- name: {{ .Values.concourse.web.service.api.tlsPort.name }}
port: {{ .Values.concourse.web.tls.bindPort }}
targetPort: atc-tls
{{- if and (eq "NodePort" .Values.web.service.api.type) .Values.web.service.api.tlsNodePort }}
Expand Down
8 changes: 8 additions & 0 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2239,6 +2239,14 @@ web:
##
tlsNodePort:

## When using thirdy party service mesh providers such as istio, port name ovverrides can be set to meet the default `http` naming convention
##
port:
name: atc

tlsPort:
name: atc-tls

workerGateway:
## For minikube, set this to ClusterIP, elsewhere use LoadBalancer or NodePort
## Ref: https://kubernetes.io/docs/user-guide/services/#publishing-services---service-types
Expand Down