Add image labels to metadata #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtremerui
reviewed
Jul 8, 2021
| @@ -76,6 +76,7 @@ if [ "$skip_download" = "false" ]; then | |||
|
|
|||
| echo "$image_id" > ${destination}/image-id | |||
| docker inspect $image_id > ${destination}/docker_inspect.json | |||
| labels="$(cat ${destination}/docker_inspect.json | jq -r '.[0].Config.Labels // {} | to_entries | map("\(.key)=\(.value)") | join(", ")')" | |||
There was a problem hiding this comment.
what happens if the jq parsing encounters problem ? would it be always make labels empty only?
Could you add a test to make sure all cases are considered so it wont errored out?
xtremerui
reviewed
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the image's labels as a comma separated string to the version's metadata. Labels contain valuable metadata and in our case we encode information about the git commit that produced the image. This is useful information to display in the UI when viewing the build logs as well as the version list page when users they can use the labels to enable/disable/pin versions.
I have tested that the
$labelsvariable contains the correct comma separated string when there are labels (see screenshot) and is an empty string when there are not.