Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable postgres as the backend of vault #87

Merged
merged 2 commits into from
Jan 9, 2020
Merged

enable postgres as the backend of vault #87

merged 2 commits into from
Jan 9, 2020

Conversation

pivotal-bin-ju
Copy link
Contributor

@pivotal-bin-ju pivotal-bin-ju commented Dec 3, 2019

Fixes: concourse/prod#44

This PR can work with the forked repo: https://github.com/concourse/vault-helm
We are going to draft a PR for that later.

I created a new vault - vault-nci for test, resilience and migration purpose.
the steps are as below:

  • ln -s vault vault-nci
  • make creds-vault-nci
  • make deploy-vault-nci

You can review the PR, but DO NOT Merge the PR until the data migration is done.

@pivotal-bin-ju pivotal-bin-ju force-pushed the vault-nci branch 3 times, most recently from 7a23baf to 578b2ae Compare December 3, 2019 21:56
@pivotal-bin-ju pivotal-bin-ju changed the title IN-PROC: enable postgres as the backend of vault enable postgres as the backend of vault Dec 3, 2019
@pivotal-bin-ju pivotal-bin-ju force-pushed the vault-nci branch 8 times, most recently from f3951cb to 7ce778a Compare January 8, 2020 15:52
- terraform: add a cloudsql/postgres
- chart: use postgres as the backend

Signed-off-by: Bin Ju <[email protected]>
Copy link
Member

@cirocosta cirocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems pretty good 😁 I'm just concerned about the way that things are represented here - If you're confident that we got all set up correctly, in which case vault is removed in favor of vault-nci (the postgres-backed one) then I think we should have in this commit the removal of the old one, and the addition of the new (rather than the linking, etc) 😁

1. How to deploy `vault-nci`
1. `git clone https://github.com/concourse/vault-helm` to the `charts` (hush-house/deployments/with-creds/vault/charts) directory.
1 `ln -s vault vault-nci`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm this seems like a transitory step that has been used during development 🤔

do you plan to have the deployment named after vault-nci or `vault? I guess the former?

(just because if the latter , then we wouldn't really need #102 as the name of the service and namespace wouldn't change)

if you feel like the transition is good (checked via the scripts that ensure that we got the data transferred well), I'd say these steps aren't needed - we should have in this repo just the final configuration that reflect the environment 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've manually back-upped the /vault/data again to make the process more safe if we only keep the vault instance. Anyway the PVC is still attached to vault we could switch back to the FS backend anytime.

I agree.

after the data between `vault` and `vault-nci`, the old vault is going
to decommission, the new `vault-nci` becomes `vault`. After the change
user can only see the instance `vault`, that would be simple for the
later maintenance.

Signed-off-by: Bin Ju <[email protected]>
@vito vito marked this pull request as ready for review January 9, 2020 19:09
@vito vito merged commit 3caac2a into master Jan 9, 2020
@vito vito deleted the vault-nci branch January 9, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add well-supported storage backend for vault
3 participants