Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mamba's CLI is broken with conda=23.11.0 #608

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

mbargull
Copy link
Member

@mbargull mbargull commented Dec 5, 2023

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.
mamba install --yes --quiet 'conda-forge-ci-setup=3.*' 'conda-smithy>=3.7.1,<4.0.0a0' conda-forge-pinning 'conda-build>=3.16' 'gitpython>=3.0.8,<3.1.20' requests ruamel.yaml 'pygithub>=2.1.1'
Currently, only install, create, list, search, run, info, clean, remove, update, repoquery, activate and deactivate are supported through mamba.

refs:

================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
osx-arm64::mamba-1.5.2-py311hb045da1_1.conda
osx-arm64::mamba-1.5.3-py310ha5d4528_1.conda
osx-arm64::mamba-1.5.3-py312h14bc7db_2.conda
osx-arm64::mamba-1.5.3-py311hb045da1_2.conda
osx-arm64::mamba-1.5.2-py38hb2d7053_1.conda
osx-arm64::mamba-1.5.3-py38hb2d7053_2.conda
osx-arm64::mamba-1.5.3-py311hb045da1_1.conda
osx-arm64::mamba-1.5.3-py39ha55b623_2.conda
osx-arm64::mamba-1.5.2-py312h14bc7db_1.conda
osx-arm64::mamba-1.5.3-py310ha5d4528_2.conda
osx-arm64::mamba-1.5.3-py39ha55b623_1.conda
osx-arm64::mamba-1.5.3-py38hb2d7053_1.conda
osx-arm64::mamba-1.5.3-py312h14bc7db_1.conda
osx-arm64::mamba-1.5.2-py38hb2d7053_0.conda
osx-arm64::mamba-1.5.2-py39ha55b623_0.conda
osx-arm64::mamba-1.5.2-py39ha55b623_1.conda
osx-arm64::mamba-1.5.2-py311hb045da1_0.conda
osx-arm64::mamba-1.5.2-py310ha5d4528_0.conda
osx-arm64::mamba-1.5.2-py310ha5d4528_1.conda
-    "conda >=23.9,<24",
+    "conda >=23.9,<23.11.0",
================================================================================
================================================================================
linux-ppc64le
linux-ppc64le::mamba-1.5.2-py310h400a96e_1.conda
linux-ppc64le::mamba-1.5.2-py312hff23a77_1.conda
linux-ppc64le::mamba-1.5.2-py38h8e2b860_0.conda
linux-ppc64le::mamba-1.5.3-py310h400a96e_2.conda
linux-ppc64le::mamba-1.5.3-py39h82e2c57_1.conda
linux-ppc64le::mamba-1.5.2-py38h8e2b860_1.conda
linux-ppc64le::mamba-1.5.2-py311haa85789_0.conda
linux-ppc64le::mamba-1.5.2-py311haa85789_1.conda
linux-ppc64le::mamba-1.5.3-py39ha24e7b4_2.conda
linux-ppc64le::mamba-1.5.2-py310h400a96e_0.conda
linux-ppc64le::mamba-1.5.2-py39ha24e7b4_1.conda
linux-ppc64le::mamba-1.5.3-py38h8e2b860_2.conda
linux-ppc64le::mamba-1.5.2-py39h82e2c57_1.conda
linux-ppc64le::mamba-1.5.3-py311haa85789_2.conda
linux-ppc64le::mamba-1.5.3-py39h82e2c57_2.conda
linux-ppc64le::mamba-1.5.3-py312hff23a77_2.conda
linux-ppc64le::mamba-1.5.3-py39ha24e7b4_1.conda
linux-ppc64le::mamba-1.5.3-py311haa85789_1.conda
linux-ppc64le::mamba-1.5.2-py39ha24e7b4_0.conda
linux-ppc64le::mamba-1.5.2-py39h82e2c57_0.conda
linux-ppc64le::mamba-1.5.3-py310h400a96e_1.conda
linux-ppc64le::mamba-1.5.3-py38h8e2b860_1.conda
linux-ppc64le::mamba-1.5.3-py312hff23a77_1.conda
-    "conda >=23.9,<24",
+    "conda >=23.9,<23.11.0",
================================================================================
================================================================================
linux-aarch64
linux-aarch64::mamba-1.5.2-py39h927961e_0.conda
linux-aarch64::mamba-1.5.2-py39h927961e_1.conda
linux-aarch64::mamba-1.5.2-py310hcbdc16a_1.conda
linux-aarch64::mamba-1.5.2-py39h83cf0c7_1.conda
linux-aarch64::mamba-1.5.3-py310hcbdc16a_1.conda
linux-aarch64::mamba-1.5.3-py312hd80a4d2_2.conda
linux-aarch64::mamba-1.5.2-py312hd80a4d2_1.conda
linux-aarch64::mamba-1.5.3-py311hb6c5aa6_2.conda
linux-aarch64::mamba-1.5.3-py311hb6c5aa6_1.conda
linux-aarch64::mamba-1.5.3-py312hd80a4d2_1.conda
linux-aarch64::mamba-1.5.3-py38hf92fa3f_2.conda
linux-aarch64::mamba-1.5.3-py39h927961e_2.conda
linux-aarch64::mamba-1.5.3-py39h927961e_1.conda
linux-aarch64::mamba-1.5.2-py311hb6c5aa6_0.conda
linux-aarch64::mamba-1.5.2-py311hb6c5aa6_1.conda
linux-aarch64::mamba-1.5.3-py39h83cf0c7_1.conda
linux-aarch64::mamba-1.5.3-py39h83cf0c7_2.conda
linux-aarch64::mamba-1.5.3-py38hf92fa3f_1.conda
linux-aarch64::mamba-1.5.3-py310hcbdc16a_2.conda
linux-aarch64::mamba-1.5.2-py38hf92fa3f_0.conda
linux-aarch64::mamba-1.5.2-py39h83cf0c7_0.conda
linux-aarch64::mamba-1.5.2-py310hcbdc16a_0.conda
linux-aarch64::mamba-1.5.2-py38hf92fa3f_1.conda
-    "conda >=23.9,<24",
+    "conda >=23.9,<23.11.0",
================================================================================
================================================================================
noarch
================================================================================
================================================================================
win-64
win-64::mamba-1.5.3-py311h8cb466b_2.conda
win-64::mamba-1.5.2-py39hca8391b_1.conda
win-64::mamba-1.5.3-py39h749ce95_1.conda
win-64::mamba-1.5.2-py311h8cb466b_1.conda
win-64::mamba-1.5.2-py38hc9c81c8_0.conda
win-64::mamba-1.5.3-py39hca8391b_2.conda
win-64::mamba-1.5.3-py311h8cb466b_1.conda
win-64::mamba-1.5.3-py312h5494d5c_2.conda
win-64::mamba-1.5.2-py311h8cb466b_0.conda
win-64::mamba-1.5.2-py38hc9c81c8_1.conda
win-64::mamba-1.5.2-py39h749ce95_0.conda
win-64::mamba-1.5.2-py39h749ce95_1.conda
win-64::mamba-1.5.2-py310hd9d798f_0.conda
win-64::mamba-1.5.2-py312h5494d5c_1.conda
win-64::mamba-1.5.2-py310hd9d798f_1.conda
win-64::mamba-1.5.3-py310hd9d798f_2.conda
win-64::mamba-1.5.3-py39hca8391b_1.conda
win-64::mamba-1.5.3-py38hc9c81c8_1.conda
win-64::mamba-1.5.2-py39hca8391b_0.conda
win-64::mamba-1.5.3-py39h749ce95_2.conda
win-64::mamba-1.5.3-py312h5494d5c_1.conda
win-64::mamba-1.5.3-py38hc9c81c8_2.conda
win-64::mamba-1.5.3-py310hd9d798f_1.conda
-    "conda >=23.9,<24",
+    "conda >=23.9,<23.11.0",
================================================================================
================================================================================
osx-64
osx-64::mamba-1.5.3-py39h412838c_2.conda
osx-64::mamba-1.5.2-py311h8082e30_0.conda
osx-64::mamba-1.5.3-py39h053c3d7_1.conda
osx-64::mamba-1.5.3-py39h412838c_1.conda
osx-64::mamba-1.5.2-py38h2cdcfb1_1.conda
osx-64::mamba-1.5.3-py312ha12221d_2.conda
osx-64::mamba-1.5.3-py38h2cdcfb1_1.conda
osx-64::mamba-1.5.2-py38h2cdcfb1_0.conda
osx-64::mamba-1.5.3-py311h8082e30_1.conda
osx-64::mamba-1.5.2-py310h6bde348_1.conda
osx-64::mamba-1.5.3-py310h6bde348_1.conda
osx-64::mamba-1.5.3-py310h6bde348_2.conda
osx-64::mamba-1.5.2-py311h8082e30_1.conda
osx-64::mamba-1.5.2-py39h412838c_0.conda
osx-64::mamba-1.5.2-py39h412838c_1.conda
osx-64::mamba-1.5.3-py311h8082e30_2.conda
osx-64::mamba-1.5.3-py312ha12221d_1.conda
osx-64::mamba-1.5.2-py312ha12221d_1.conda
osx-64::mamba-1.5.2-py39h053c3d7_0.conda
osx-64::mamba-1.5.2-py39h053c3d7_1.conda
osx-64::mamba-1.5.3-py38h2cdcfb1_2.conda
osx-64::mamba-1.5.2-py310h6bde348_0.conda
osx-64::mamba-1.5.3-py39h053c3d7_2.conda
-    "conda >=23.9,<24",
+    "conda >=23.9,<23.11.0",
================================================================================
================================================================================
linux-64
linux-64::mamba-1.5.3-py312h9460a1c_1.conda
linux-64::mamba-1.5.3-py39hc5d2bb1_1.conda
linux-64::mamba-1.5.2-py311h3072747_0.conda
linux-64::mamba-1.5.3-py38haad2881_2.conda
linux-64::mamba-1.5.3-py39hcbb6966_1.conda
linux-64::mamba-1.5.2-py311h3072747_1.conda
linux-64::mamba-1.5.2-py39hcbb6966_0.conda
linux-64::mamba-1.5.3-py310h51d5547_1.conda
linux-64::mamba-1.5.3-py311h3072747_1.conda
linux-64::mamba-1.5.3-py311h3072747_2.conda
linux-64::mamba-1.5.2-py39hc5d2bb1_0.conda
linux-64::mamba-1.5.3-py38haad2881_1.conda
linux-64::mamba-1.5.2-py310h51d5547_0.conda
linux-64::mamba-1.5.3-py39hc5d2bb1_2.conda
linux-64::mamba-1.5.3-py312h9460a1c_2.conda
linux-64::mamba-1.5.2-py39hc5d2bb1_1.conda
linux-64::mamba-1.5.2-py39hcbb6966_1.conda
linux-64::mamba-1.5.2-py38haad2881_1.conda
linux-64::mamba-1.5.3-py310h51d5547_2.conda
linux-64::mamba-1.5.3-py39hcbb6966_2.conda
linux-64::mamba-1.5.2-py310h51d5547_1.conda
linux-64::mamba-1.5.2-py312h9460a1c_1.conda
linux-64::mamba-1.5.2-py38haad2881_0.conda
-    "conda >=23.9,<24",
+    "conda >=23.9,<23.11.0",

@mbargull mbargull requested a review from a team as a code owner December 5, 2023 10:29
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mbargull mbargull marked this pull request as draft December 5, 2023 10:42
@mbargull mbargull force-pushed the conda-23.11-mamba-cli branch from 5b39cca to fb0ec4f Compare December 5, 2023 10:50
@mbargull
Copy link
Member Author

mbargull commented Dec 5, 2023

python show_diff.py is empty?

@mbargull mbargull force-pushed the conda-23.11-mamba-cli branch from fb0ec4f to af50236 Compare December 5, 2023 11:01
Trying replace_depends since tighted_depends did not work.

Signed-off-by: Marcel Bargull <[email protected]>
@mbargull mbargull force-pushed the conda-23.11-mamba-cli branch from af50236 to fe7b3a0 Compare December 5, 2023 11:09
@mbargull mbargull marked this pull request as ready for review December 5, 2023 11:10
@mbargull
Copy link
Member Author

mbargull commented Dec 5, 2023

python show_diff.py is empty?

tighten_depends did not work.
IDK if that is a known issue.
Used replace_depends on the one added via conda-forge/mamba-feedstock@8670b30#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR129 .

@ocefpaf ocefpaf merged commit d88e351 into conda-forge:main Dec 5, 2023
4 checks passed
timestamp_lt: 1701773340000
then:
- replace_depends:
old: conda >=23.9,<24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this permissive pin is what made this compatibility issue a lot more pressing than it should be.

@mbargull
Copy link
Member Author

mbargull commented Dec 5, 2023

@conda-forge/core: Does anyone have a good idea how to address mamba-org/mamba#3033 (comment) until we have a new mamba release packaged?

I just checked if it works as intended an indeed an create conda=23.11 mamba prevents the env creation as intended.
... But mamba install conda=23.11 and CONDA_SOLVER=libmamba conda install conda=23.11 into an environment with mamba already installed still succeeds (leaving mamba non-functional afterwards). (Could be something with preferring dependency info from installed packages over conflicting ones coming from the channel?)
So, we probably need better/additional fixes (possibly/hopefully with a newer mamba version it will just install that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants