-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pixi #798
base: main
Are you sure you want to change the base?
Add pixi #798
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
is a pixi lock file for a "small project" such as this really 5k lines long? |
It will become a little shorter soon (we remove some duplicate data in a upcoming PR). But yeah, since we need the repodata records it is rather long. |
I think the approach from I could definitely see a useful
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also add some documentation to recipe/README.md
to alert contributors that the pixi
configuration exists and how they can use it to test their patches? I'm imagining something similar to #675 where I added a conda env file
show-diff = "python ./show_diff.py" | ||
|
||
[dependencies] | ||
annotated-types = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already a dependency of pydantic
...
conda-build = "*" | ||
license-expression = "*" | ||
pre-commit = "*" | ||
pydantic = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I... don't believe this can be *
... I'd wager 2.*
might be safe, but there are a lot of pins out there...
platforms = ["osx-arm64", "linux-64", "win-64"] | ||
|
||
[tasks] | ||
show-diff = "python ./show_diff.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this is:
- very expensive, I recommend adding a
description
noting that - _very_verbose, probably also a task which writes it out to a
> {git branch}.txt
annotated-types = "*" | ||
conda-build = "*" | ||
license-expression = "*" | ||
pre-commit = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit
isn't going to fire unless inside a shell
... having a task.lint
that runs all the linters against all the files would likely be helpful.
I'm not convinced checking in the |
Checklist
generate_patch_json.py
if absolutely necessary.pre-commit run -a
and ensured all files pass the linting checks.python show_diff.py
and posted the output as part of the PR.