-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Update to 1.0.0 alpha2 #36
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
In summary, we only have mujoco-py and mujoco issues which is good
|
I also removed the cython dependency from gymnasium-mujoco as it appears it is not used there. |
@traversaro I've cut alpha 2, however, this is causing new strange issues, do you understand what the problem is? |
Do you refer to the Or perhaps you were referring to something else? |
Yes, looking at the logic in Farama-Foundation/Gymnasium#934 it seems that before just running |
Ok, new round of errors:
This seems just due to the fact that the Other failures:
This seems to be real errors, any idea @pseudo-rnd-thoughts ? |
On some configurations there are a
but this problems are not related to gymnasium, probably some wrong metadata. |
Indeed it was some problem in metadata of chex (conda-forge/chex-feedstock#21) and optax (conda-forge/optax-feedstock#19). The proper solution would be to prepare a repodata patch, but given that Python 3.8 is close to EOL, I guess we can just skip |
The precise line is:
Perhaps is just a usual problem of |
Thanks for looking at this Good point, I suspect that you're right. |
Another win-64 failure:
That is strange, it selects the mujoco==3.1.2/3.1.3 path even if mujoco 3.1.5 is installed. |
|
This happened on Python 3.8, as jax does not support anymore python 3.8 so an old jax that forced the use of an old mujoco was installed. I think we can skip jax tests on Python 3.8 . |
It is a bit of a long story, but a lot of strange dependency resolution are due to:
|
Still a failure on python==3.8 on linux-64 :
Windows is still failing for conda-forge/libavif-feedstock#32, while aarch64 is failing now with the segfault when collecting tests, after I disabled jax due to conda-forge/jax-feedstock#144 . |
I tried in a local build and indeed the aarch64 pytest collection was failing (even if not segfaulting) with:
deleting these files before the pytest invocation solved the segfault in pytest collection. |
The segfault were probably related to opencv requiring CDTs libraries, that however in a cross-compiling environment where tests are emulate are not available. Hopefully in the long term conda-forge/staged-recipes#25919 should mitigate these problems. |
Amazing, thanks for your hardwork @traversaro, really appreciate it (apologies about closing the PR accidently) I've accepted all your Gymnasium PRs, is there anything super weird we don't understand yet or is it manageable problems? |
There are a bit of strange test failure on aarch64, but the more I look into them the more are either other packages problems or weird combinaiton of cross compilation + CDT. As the vast majority of tests on aarch64 are passing fine, I think we can just suppress the failing errors on aarch64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Only a few small comments. The aarch segfaults are a bit scary, but I don't think it's the fault of this recipe. We might want to try updating to latest QEMU (though that's a cf-infra task), and see if that changes anything.
Also, if python 3.8 is becoming an outsized burden, I wouldn't hesitate too much to just drop it. It's EOL in less than half a year.
# https://github.com/Farama-Foundation/Gymnasium/pull/1060 | ||
- 1060.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to be consistent and also move this into the patches
folder
Co-authored-by: h-vetinari <[email protected]>
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)