Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for assimp 5.4.3 #45

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update assimp543.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

The failure is due to gazebosim/gz-common#633 that was fixed in gazebosim/gz-common#634, let's backport that patch.

@Tobias-Fischer
Copy link
Contributor

Hi @traversaro - I fixed the patch for v5. However, I noticed this in the v5 branch:
https://github.com/gazebosim/gz-common/blob/2faf830f480aba419d3dade55dad731fdf147add/graphics/src/AssimpLoader.cc#L659-L660

That comment (and the 1.0 - Y) have disappeared in v6. I am not sure if v5 needs the 1.0 - Y or not .. do you happen to know any more?

@traversaro
Copy link
Contributor

I am not sure, perhaps we can just monitor gazebosim/gz-common#641 and backport it once it has been cleaned up?

@Tobias-Fischer
Copy link
Contributor

Looks like this did the trick - what do you think @traversaro?

@Tobias-Fischer Tobias-Fischer added the automerge Merge the PR when CI passes label Sep 23, 2024
@github-actions github-actions bot merged commit 7bda297 into conda-forge:main Sep 23, 2024
14 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-assimp543-0-1_h8e7b06 branch September 23, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants