Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build minimal-static on win #89

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

AntoinePrv
Copy link

@AntoinePrv AntoinePrv commented Apr 8, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@AntoinePrv AntoinePrv mentioned this pull request Apr 9, 2024
5 tasks
@AntoinePrv AntoinePrv marked this pull request as draft April 9, 2024 12:21
@AntoinePrv AntoinePrv force-pushed the win-static branch 2 times, most recently from 92c1801 to 0172a70 Compare April 10, 2024 09:18
@AntoinePrv AntoinePrv force-pushed the win-static branch 3 times, most recently from ba381dd to f131fd9 Compare April 10, 2024 12:25
@AntoinePrv AntoinePrv marked this pull request as ready for review April 10, 2024 13:15
@AntoinePrv
Copy link
Author

@conda-forge/libarchive This enables libarchive-minimal-static on Windows, which we use on Unix for micromamba.
Hopefully this can get us around the xz problems we have with VCPKG.

@AntoinePrv AntoinePrv marked this pull request as draft April 11, 2024 09:30
@AntoinePrv AntoinePrv marked this pull request as ready for review April 11, 2024 15:22
@AntoinePrv
Copy link
Author

Now even better by building the static lib with other static libs just for safety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant