Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump 3.7.7 #98

Merged
merged 4 commits into from
Nov 26, 2024
Merged

bump 3.7.7 #98

merged 4 commits into from
Nov 26, 2024

Conversation

jafraustro
Copy link
Contributor

@jafraustro jafraustro commented Oct 24, 2024

comment two patches

Checklist

comment two patches
@jafraustro
Copy link
Contributor Author

@conda-forge-admin , please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jafraustro
Copy link
Contributor Author

Hi @ocefpaf,
The build in #97 failed do to patches: 0003-VC9 and 0004-VC9

I'm not an expert—do you know if these patches are still necessary? Also, is there a reason why libarchive has not been updated? The build in #96 was successful.

@jafraustro jafraustro marked this pull request as ready for review October 28, 2024 19:21
@ocefpaf
Copy link
Member

ocefpaf commented Oct 29, 2024

I'm not an expert—do you know if these patches are still necessary?

We need to check if they were upstreamed or if they need to be refreshed due to code change.

Also, is there a reason why libarchive has not been updated? The build in #96 was successful.

B/c no one had the time to do the above 😬

@AndresGuzman-Ballen
Copy link
Contributor

AndresGuzman-Ballen commented Nov 20, 2024

Looks like the patches don't apply because the upstream code had made some minor modifications to some header files (like checking whether Windows version is XP or older): https://github.com/libarchive/libarchive/pull/2374/files. I don't know what the ramifications are for 0003 patch either (which needs to take into account new updates to CMakeLists.txt: libarchive/libarchive@v3.7.4...v3.7.7#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a)

@ocefpaf
Copy link
Member

ocefpaf commented Nov 21, 2024

We probably need to refresh those patches then.

@AndresGuzman-Ballen
Copy link
Contributor

@ocefpaf I refreshed them :) jafraustro#1 I created the PR against jafraustro:3_7_7 so we didn't close this PR though

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

@jafraustro
Copy link
Contributor Author

Hi, @ocefpaf
can you give a look? please

@ocefpaf ocefpaf merged commit 55b9b0b into conda-forge:main Nov 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants