Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump build number and rebuild against latest libavif on Windows #22

Merged
merged 3 commits into from
May 29, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented May 29, 2024

See conda-forge/libavif-feedstock#32 (comment) and conda-forge/libavif-feedstock#33 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from frmdstryr as a code owner May 29, 2024 14:16
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libheif-feedstock/actions/runs/9287782600.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@hmaarrfk
Copy link
Contributor

Given the last few migrations haven't taken place I'm going to jump in here since I know it is blocking @traversaro

@frmdstryr is there a particular reason why the migrations haven't been merged?
If it is just you didn't have time that is fine, we can have other co-maintainers jump in when they need to.

If you have compatibility concerns it would be great to learn about them so we can address them.

@hmaarrfk hmaarrfk merged commit 5986c56 into conda-forge:main May 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants