-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flang19 #8
base: main
Are you sure you want to change the base?
Flang19 #8
Conversation
…nda-forge-pinning 2024.10.16.14.01.38
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks for opening the PR! Responding to your comment from #7:
Yeah, I think this is a CMake issue (which is unfortunately still somewhat expected as flang is pretty new). What I did in conda-forge/openblas-feedstock#115 was:
REM https://discourse.cmake.org/t/how-to-find-openmp-with-clang-on-macos/8860
set "CMAKE_EXTRA=-DOpenMP_ROOT=%LIBRARY_LIB%"
REM not picked up by `find_package(OpenMP)` for some reason
set "CMAKE_EXTRA=-DOpenMP_Fortran_FLAGS=-fopenmp -DOpenMP_Fortran_LIB_NAMES=libomp" |
@@ -16,7 +16,7 @@ requirements: | |||
build: | |||
- {{ stdlib("c") }} | |||
- {{ compiler("fortran") }} | |||
- cmake | |||
- cmake >=3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're already getting the newest CMake anyway, however, newer policies (in CMake terminology) will still not take effect, unless the CMake minimal version as defined in CMakeLists.txt
is raised. This would need a patch of the sources (or a new upstream release with that change).
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)