Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for s390x #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ravigumm
Copy link

@ravigumm ravigumm commented Dec 1, 2020

This is to add support for linux-s390x (Linux on Z)

@ravigumm ravigumm requested a review from a team as a code owner December 1, 2020 08:18
@ravigumm
Copy link
Author

ravigumm commented Dec 1, 2020

I am able to run the following sample code to verify conda-mirror functionality on s390x.

conda create -y -n mirror_env
conda activate mirror_env
conda install -y conda-mirror

export CHANNEL_URL=<My_URL_with_http>

conda-mirror -vv --ssl-verify false --upstream-channel $CHANNEL_URL --target-directory $HOME/zconda-mirror --platform linux-s390x
conda-mirror -vv --ssl-verify false --upstream-channel $CHANNEL_URL --target-directory $HOME/zconda-mirror --platform noarch

conda index $HOME/zconda-mirror

@ericdill
Copy link

ericdill commented Dec 1, 2020

Are there any non-Anaconda channels that support linux-s390x?

@scopatz
Copy link

scopatz commented Dec 1, 2020

Thanks! Can you please add a news item: https://regro.github.io/rever-docs/news.html

@ericdill
Copy link

ericdill commented Dec 1, 2020

@scopatz if the only place where you can get these linux on Z packages is from an official Anaconda channel, then adding this capability to conda-mirror feels like probably not a great idea, especially given the recent changes to the Anaconda TOS. Thoughts?

@scopatz
Copy link

scopatz commented Dec 1, 2020

I don't know. It seems like anyone could set up a channel with the platform. IIRC this is the platform name in conda itself, so the change here just makes it compatible with conda, not Anaconda per se.

@potula-chandra
Copy link

@ericdill conda is the first community that's been looked at to support s390x platform at this point in time.

@scopatz
Copy link

scopatz commented Dec 17, 2020

I would be happy to merge this. CI seems to be failing though...

@ravigumm
Copy link
Author

Anaconda's defaults channel has s390x conda packages now.

@ravigumm
Copy link
Author

ravigumm commented Jul 14, 2021

Am not sure what this error in CI build means. How to resolve this error ?

The command "coverage report -m" exited with 0.

1.82s$ make format-check

black --check .

would reformat conda_mirror/conda_mirror.py

Oh no! 💥 💔 💥

1 file would be reformatted, 10 files would be left unchanged.

Makefile:27: recipe for target 'format-check' failed

make: *** [format-check] Error 1

The command "make format-check" exited with 2.

0.81s$ make lint

flake8

The command "make lint" exited with 0.

@xhochy
Copy link
Member

xhochy commented Jul 14, 2021

This means that you should format your code changes with black. Running black . locally should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants