Add python_requires>=3.6 and a conda recipe #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
requested changes
Jul 14, 2021
| path: .. | ||
|
|
||
| build: | ||
| script: python setup.py install --single-version-externally-managed --record=record.txt |
There was a problem hiding this comment.
Suggested change
| script: python setup.py install --single-version-externally-managed --record=record.txt | |
| script: pip install -vv . |
There was a problem hiding this comment.
These changes actually break the script install. It ends up requiring the version of python used to build it.
There was a problem hiding this comment.
The recipe produces a noarch python recipe that can be installed on any platform or supported version of python. But if the suggested changes are made, the resulting conda-recipe script will only be runnable on the version of python it was built on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a python_requires>=3.6 attribute to setup.py.
The code already assumes at least python 3.6, so we may just as well make it explicit in the package metadata.
The conda.recipe can be used to directly build a conda package that you can test locally or deploy to private channels.