Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with --include-depends #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

analog-cbarber
Copy link

If your whitelist specified a constraint like 'python=999',
that does not match anything in the channel, then some indirect
dependency of a package could then bring in other versions
of python. Really, we want the whitelist constraints to still
be honored at least for explicitly named packages
(i.e. where the whitelist specifies an exact package name,
not a glob expression).

This change fixes that and gives you better control over
what extra packages get added by --include-depends.

If your whitelist specified a constraint like 'python=999',
that does not match anything in the channel, then some indirect
dependency of a package could then bring in other versions
of python. Really, we want the whitelist constraints to still
be honored at least for explicitly named packages
(i.e. where the whitelist specifies an exact package name,
not a glob expression).

This change fixes that and gives you better control over
what extra packages get added by --include-depends.
@analog-cbarber analog-cbarber requested a review from a team as a code owner July 16, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant