Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picosat.c build error #35

Open
ThePrez opened this issue Jun 27, 2019 · 2 comments · May be fixed by #37
Open

picosat.c build error #35

ThePrez opened this issue Jun 27, 2019 · 2 comments · May be fixed by #37
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release source::community catch-all for issues filed by community members stale::recovered [bot] recovered after being marked as stale type::feature request for a new feature or capability

Comments

@ThePrez
Copy link

ThePrez commented Jun 27, 2019

picosat.c has #include <sys/unistd.h> but on some systems it should just be #include <unistd.h>

The build error on IBM i is manifested as:

    In file included from pycosat.c:19:0:
    picosat.c:8150:24: fatal error: sys/unistd.h: No such file or directory
     #include <sys/unistd.h>
                            ^

To solve my immediate concern, one could simply #ifdef __PASE__ (defined on IBM i), but I am opening an issue rather than a PR so the project owners can choose their preferred way to address.

Thanks!

@ThePrez ThePrez linked a pull request May 13, 2020 that will close this issue
@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Mar 15, 2022
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label May 14, 2022
@github-actions github-actions bot moved this to Done in 🧭 Planning May 14, 2022
@jezdez jezdez reopened this Oct 14, 2022
@jezdez jezdez added stale::recovered [bot] recovered after being marked as stale and removed stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity labels Oct 14, 2022
@kenodegard kenodegard added type::feature request for a new feature or capability source::community catch-all for issues filed by community members in-progress issue is actively being worked on labels Sep 5, 2023
@kenodegard kenodegard moved this from 🏁 Done to 👀 In Review in 🧭 Planning Sep 5, 2023
@kenodegard kenodegard added backlog issue has been triaged but has not been earmarked for any upcoming release and removed in-progress issue is actively being worked on labels Sep 27, 2023
@dholth
Copy link
Contributor

dholth commented Oct 18, 2023

I was able to include just unistd.h on osx

#include <unistd.h>

int main(int argc, char **argv) {
    return 0;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release source::community catch-all for issues filed by community members stale::recovered [bot] recovered after being marked as stale type::feature request for a new feature or capability
Projects
Status: 👀 In Review
Development

Successfully merging a pull request may close this issue.

4 participants