Run JavaScript linter in CI

.eslintrc.json

@@ -19,11 +19,13 @@
     "assets/js/scripts.js",
     "assets/js/tinymce-shortcode.js",
     "assets/js/asp-ajax.js",
-    "assets/js/decree-search.js"
+    "assets/js/decree-search.js",
+    "src/js/typewriter-effect.min.js"
   ],
   "rules": {
     "no-param-reassign": 0,
     "no-shadow": "off",
-    "no-new": "off"
+    "no-new": "off",
+    "import/extensions": ["error", "always"]
   }
 }

.github/workflows/test.yml

@@ -26,8 +26,11 @@ jobs:
             name: Install dependencies
             run: npm ci
         -
-            name: Run linter
+            name: Run SASS linter
             run: npm run sass:lint
+        -
+            name: Run JavaScript linter
+            run: npm run js:lint
         -
             name: Check EditorConfig configuration
             run: test -f .editorconfig

package.json

@@ -42,8 +42,8 @@
     "stylelint-order": "^6.0.3"
   },
   "engines": {
-    "node": "^18.12",
-    "npm": "^9.2",
+    "node": "^20.11",
+    "npm": "^10.2",
     "yarn": "please-use-npm"
   }
 }

src/js/cookie-consent.js

@@ -3,7 +3,7 @@ import {
 } from './cookie.js';
 
 (() => {
-  const lang = document.documentElement.lang;
+  const { lang } = document.documentElement;
   const prefix = 'cone';
   const btns = document.querySelectorAll('button[data-action="cookie"]');
   let caption = '';

src/js/scripts.js

@@ -18,7 +18,7 @@ if (getCookie('cone-cookie-law-analytics') === 'accepted') {
 
   gtag('js', new Date());
   gtag('config', coneGtagId, {
-    'cookie_domain': window.location.hostname,
-    'cookie_flags': 'SameSite=None;Secure'
+    cookie_domain: window.location.hostname,
+    cookie_flags: 'SameSite=None;Secure',
   });
 }