Remove TODO-s

conedevelopment · Oct 25, 2023 · f1bfb8f · f1bfb8f
1 parent 85330e1
commit f1bfb8f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/database/factories/MediumFactory.php b/database/factories/MediumFactory.php
@@ -12,7 +12,7 @@ class MediumFactory extends Factory
     /**
      * The name of the factory's corresponding model.
      *
-     * @var string
+     * @var class-string<\Cone\Root\Models\Medium>
      */
     protected $model = Medium::class;
 

diff --git a/database/factories/MetaFactory.php b/database/factories/MetaFactory.php
@@ -11,7 +11,7 @@ class MetaFactory extends Factory
     /**
      * The name of the factory's corresponding model.
      *
-     * @var string
+     * @var class-string<\Cone\Root\Models\Meta>
      */
     protected $model = Meta::class;
 

diff --git a/database/factories/NotificationFactory.php b/database/factories/NotificationFactory.php
@@ -11,7 +11,7 @@ class NotificationFactory extends Factory
     /**
      * The name of the factory's corresponding model.
      *
-     * @var string
+     * @var class-string<\Cone\Root\Models\Notification>
      */
     protected $model = Notification::class;
 

diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -1,6 +1,6 @@
 includes:
     - vendor/nunomaduro/larastan/extension.neon
-#    - phpstan-baseline.neon
+    - phpstan-baseline.neon
 parameters:
     databaseMigrationsPath:
         - database/migrations/
@@ -11,8 +11,7 @@ parameters:
     paths:
         - src/
         - config/
-# TODO
-#        - database/
+        - database/
         - routes/
     level: 5
     checkAlwaysTrueCheckTypeFunctionCall: true
@@ -28,8 +27,7 @@ parameters:
     checkInternalClassCaseSensitivity: true
     ignoreErrors:
         - '#^Unsafe usage of new static#'
-        # --- TODO-s ---
-        # X vs. X contract
-        - '#but returns Illuminate\\Contracts\\#'
+        # Illuminate\View\View vs. Illuminate\Contracts\View\View
+        - '#^Method Cone\\\S+::render\(\) should return Illuminate\\View\\View but returns Illuminate\\Contracts\\View\\View\.$#'
         # SoftDeletes
         - '#(\$forceDeleting|::withTrashed|::onlyTrashed|::trashed|::restore)#'