Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trait detection #218

Closed
wants to merge 3 commits into from
Closed

trait detection #218

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
784209c
trait detection
szepeviktor Jun 27, 2024
209c72c
Update Action.php
szepeviktor Jun 27, 2024
4d3e71a
Update Action.php
szepeviktor Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Actions/Action.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
$field->setAttribute('form', $this->getKey());
$field->id($this->getKey().'-'.$field->getAttribute('id'));
$field->resolveErrorsUsing(function (Request $request): MessageBag {
return $this->errors($request);

Check failure on line 135 in src/Actions/Action.php

View workflow job for this annotation

GitHub Actions / 3️⃣ Static Analysis 

Anonymous function should return Illuminate\Support\MessageBag but returns Illuminate\Contracts\Support\MessageBag.
});

if ($field instanceof Relation) {
Expand Down Expand Up @@ -213,7 +213,8 @@

if (in_array(HasRootEvents::class, class_uses_recursive($model))) {
$models->each(static function (Model $model) use ($request): void {
/** @phpstan-assert \Cone\Root\Traits\HasRootEvents $model */
$model->recordRootEvent(

Check failure on line 217 in src/Actions/Action.php

View workflow job for this annotation

GitHub Actions / 3️⃣ Static Analysis 

Call to an undefined method Illuminate\Database\Eloquent\Model::recordRootEvent().
Str::of(static::class)->classBasename()->headline()->value(),
$request->user()
);
Expand Down
Loading