Build website in CI #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@szepeviktor I could add it, but it is a private URL. How can I add it? |
|
@szepeviktor I mean without exposing it? |
|
In a GitHub Repository secret. But that makes the whole project private. |
|
I think then it would be best to make a dummy endpoint with fewer examples. It is not a concern right now but could be in the future, so I still want the right endpoint hidden. |
|
I've made a fix to this. Now if there is no URL we give back two fake data. |
|
Thanks for the PR and for resolving the conflict! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adamlaki What is the URL?
Could you add it?