HTTPProxy: remove message patch

HTTP jump service requests save valid addresses to in-memory
address book, separating storage from HTTP message processing.

Refs monero-project#835 + monero-project#838

src/client/proxy/http.cc

@@ -308,7 +308,7 @@ void HTTPProxyHandler::HandleStreamRequestComplete(
 }
 /// @brief all this to change the useragent
 /// @param len length of string
-bool HTTPMessage::CreateHTTPRequest(const bool save_address) {
+bool HTTPMessage::CreateHTTPRequest() {
   if (!ExtractIncomingRequest()) {
     // m_ErrorResponse is set in ExtractIncomingRequest
     return false;
@@ -338,7 +338,7 @@ bool HTTPMessage::CreateHTTPRequest(const bool save_address) {
           // - continue without saving option
 
           // TODO(unassigned): separate this from message handling
-          if (!SaveJumpServiceAddress() && save_address)
+          if (!SaveJumpServiceAddress())
             {
               LOG(error)
                   << "HTTPProxyHandler: failed to save address to address book";

src/client/proxy/http.h

@@ -237,10 +237,8 @@ class HTTPMessage : public std::enable_shared_from_this<HTTPMessage>{
 
   /// @brief Processes original request: extracts, validates,
   ///   calls jump service, appends original request
-  /// @param save_address Save address to disk
   /// @return true on success
-  // TODO(unassigned): save address param is a hack until storage is separated from message
-  bool CreateHTTPRequest(const bool save_address = true);
+  bool CreateHTTPRequest();
 
   const unsigned int HEADERBODY_LEN = 2;
   const unsigned int REQUESTLINE_HEADERS_MIN = 1;