test/e2e: docker: Fix KBS test that doesn't compile #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing the tests for me at the moment: The KBS log shows that no get requests were made during this testing: there is an error in the set secret though: I'll try debugging this further, unless @liudalibj you've already looked into this/can spot that |
stevenhorsman
force-pushed
the
docker-provider-kbs-fix
branch
from
b0cbe27 to
223bc8e
Compare
|
Ok, I've tried the libvirt tests locally to see what the difference is and they fail in the same way. @liudalibj - did you have them working in #1935? is there some catch I'm doing wrong? Update I decided to be sensible and check the nightly libvrt tests and they are working, so the failure is probably either user error, or related to us not using the latest CAA by default? |
wainersm
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
I confirm it fix the compilation issue. Thanks @stevenhorsman !
liudalibj
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
@stevenhorsman I didn't look into this issue yet. thanks the fix!
LGTM
liudalibj
reviewed
Aug 12, 2024
| @@ -101,10 +101,11 @@ func TestDockerKbsKeyRelease(t *testing.T) { | |||
| if !isTestWithKbs() { | |||
| t.Skip("Skipping kbs related test as kbs is not deployed") | |||
| } | |||
| _ = keyBrokerService.EnableKbsCustomizedPolicy("deny_all.rego") | |||
| keyBrokerService.SetSampleSecretKey() | |||
There was a problem hiding this comment.
didn't have the return _ val, maybe won't pass lint check.
As part of the work in confidential-containers#1935, EnableKbsCustomizedPolicy was replaced with EnableKbsCustomizedResourcePolicy and EnableKbsCustomizedAttestationPolicy, but the docker tests wasn't updated, so it doesn't compile, so fix this Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
force-pushed
the
docker-provider-kbs-fix
branch
from
223bc8e to
448ee25
Compare
|
I think we should merge this as it unblocks multiple other PRs, but I'm not super happy that I couldn't get this working properly locally, so we might have to fix something here as part of the docker e2e tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work in #1935, EnableKbsCustomizedPolicy was replaced with EnableKbsCustomizedResourcePolicy and EnableKbsCustomizedAttestationPolicy, but the docker tests wasn't updated, so it doesn't compile, so fix this