libvirt: Add podvm instance cpu and mem size support for libvirt #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savitrilh
force-pushed
the
libvirt-resource
branch
from
628f293 to
5c98498
Compare
Add podvm instance cpu and mem size support for libvirt Fixes: confidential-containers#1650 Signed-off-by : SAVITRI HUNASHEEKATTI <[email protected]>
savitrilh
force-pushed
the
libvirt-resource
branch
from
5c98498 to
951f560
Compare
Add podvm instance cpu and mem size support for libvirt Fixes: confidential-containers#1650 Signed-off-by : SAVITRI HUNASHEEKATTI <[email protected]>
Add podvm instance cpu and mem size support for libvirt Fixes: confidential-containers#1650 Signed-off-by : SAVITRI HUNASHEEKATTI <[email protected]>
savitrilh
force-pushed
the
libvirt-resource
branch
2 times, most recently
from
ca6e52a to
0bf4a2d
Compare
Removed extra closing bracket Signed-off-by : SAVITRI HUNASHEEKATTI <[email protected]>
savitrilh
force-pushed
the
libvirt-resource
branch
from
0bf4a2d to
36c06e3
Compare
stevenhorsman
requested changes
Jan 8, 2025
Comment on lines
34
to
35
| // Convert Memory size from MegaBytes to GigaBytes | ||
| LIBVIRT_CONV_MEM = 1000 |
There was a problem hiding this comment.
The kata annotation is in MiB (https://github.com/kata-containers/kata-containers/blob/main/docs/how-to/how-to-set-sandbox-config-kata.md#hypervisor-options) and the domainXML we create is in GiB (
), so the comment and conversion constant needs correcting.| @@ -56,9 +56,12 @@ func (p *libvirtProvider) CreateInstance(ctx context.Context, podName, sandboxID | |||
| return nil, err | |||
| } | |||
|
|
|||
| // TODO: Specify the maximum instance name length in Libvirt | |||
| vm := &vmConfig{name: instanceName, userData: userData, firmware: p.serviceConfig.Firmware} | |||
| // Convert the memory units in gigabytes | |||
There was a problem hiding this comment.
This comment need updating too.
Comment on lines
+155
to
+156
| [[ "${LIBVIRT_CPU}" ]] && optionals+="-CPU ${LIBVIRT_CPU} " | ||
| [[ "${LIBVIRT_MEMORY}" ]] && optionals+="-Memory ${LIBVIRT_MEMORY} " |
There was a problem hiding this comment.
It looks like convention is for the flags to be lowercase
| @@ -28,6 +28,8 @@ configMapGenerator: | |||
| - LIBVIRT_EFI_FIRMWARE="/usr/share/OVMF/OVMF_CODE_4M.fd" # Edit to change the EFI firmware path, or comment to unset, if not using EFI. | |||
| #- LIBVIRT_LAUNCH_SECURITY="" #sev or s390-pv | |||
| #- LIBVIRT_VOL_NAME="" # Uncomment and set if you want to use a specific volume name. Defaults to podvm-base.qcow2 | |||
| #- LIBVIRT_CPU="2" | |||
| #- LIBVIRT_Memory="800 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use io.katacontainers.config.hypervisor.default_vcpus and io.katacontainers.config.hypervisor.default_memory annotations to set the libvirt podvm instance. Use the default values if no annotations are provided.
Fixes: #1650
Signed-off-by : savitrilh [email protected]