Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podvm: aws: set shutdown_behavior to terminate #2230

Merged

Conversation

snir911
Copy link
Contributor

@snir911 snir911 commented Jan 9, 2025

to avoid dangling VMs

@snir911 snir911 requested a review from bpradipt January 9, 2025 09:31
@snir911 snir911 self-assigned this Jan 9, 2025
@snir911 snir911 requested a review from a team as a code owner January 9, 2025 09:31
@snir911 snir911 force-pushed the avoid_aws_resouce_leak branch from a9415fa to cdceb76 Compare January 9, 2025 13:00
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bpradipt
Copy link
Member

bpradipt commented Jan 9, 2025

@snir911 the packer check is complaining

@snir911 snir911 force-pushed the avoid_aws_resouce_leak branch from cdceb76 to bf9fca7 Compare January 14, 2025 07:07
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@snir911 snir911 merged commit b89ad54 into confidential-containers:main Jan 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants