Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: image-rs to new version #319

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

Xynnn007
Copy link
Member

@Xynnn007 Xynnn007 commented Jan 4, 2024

in old image-rs we use Attestation Agent as a lib inside to request for keys. After some refactoring, AA remains only the attestation parts. This patch updates image-rs version after that refactoring.

see confidential-containers/guest-components#412

@Xynnn007 Xynnn007 requested a review from a team as a code owner January 4, 2024 15:05
@Xynnn007 Xynnn007 force-pushed the bump-image-rs branch 2 times, most recently from 42ac2e6 to bdde6a8 Compare January 4, 2024 15:26
@Xynnn007 Xynnn007 marked this pull request as draft January 4, 2024 15:27
@Xynnn007
Copy link
Member Author

Xynnn007 commented Jan 4, 2024

We can change the rev to confidential-containers after merging confidential-containers/guest-components#427

@Xynnn007 Xynnn007 marked this pull request as ready for review January 4, 2024 15:36
@mythi
Copy link
Contributor

mythi commented Jan 5, 2024

We can change the rev to confidential-containers after merging confidential-containers/guest-components#427

Do you think we could just wait that merge first and then update here? i.e., not merge this right now

@Xynnn007
Copy link
Member Author

Xynnn007 commented Jan 5, 2024

We can change the rev to confidential-containers after merging confidential-containers/guest-components#427

Do you think we could just wait that merge first and then update here? i.e., not merge this right now

Yes. I meant this.

@Xynnn007 Xynnn007 marked this pull request as draft January 7, 2024 02:45
in old image-rs we use Attestation Agent as a lib inside to request for
keys. After some refactoring, AA remains only the attestation parts.
This patch updates image-rs version after that refactoring.

Signed-off-by: Xynnn007 <[email protected]>
@Xynnn007 Xynnn007 marked this pull request as ready for review January 15, 2024 05:19
@Xynnn007
Copy link
Member Author

Updated the git rev to confidential-contaienrs.

@mythi mythi merged commit 763365d into confidential-containers:main Jan 15, 2024
8 checks passed
@Xynnn007 Xynnn007 deleted the bump-image-rs branch August 23, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants