Bump garm revision #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves to a newer garm and garm-provider-azure revision that has been tested and includes support for gallery images on Azure. This revision uses "log/slog" so depends on being built with go 1.21. Since the go 1.21 build container defaults to being bookworm based, specify that explicitly and use a matching bookworm debian base image for the final container. Signed-off-by: Jeremi Piotrowski <[email protected]>
mkulke
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
lgtm.
note: there is no implicit image building, you need to rebuild to get a new version pushed to ghcr.io/confidential-containers/garm:main (not ideal, it should be the rev, imo).
Did you perform some tests with a new garm build, does it come up?
There might be schema migrations on the sqlite store, so we also need to test whether it works with the existing db content (and pin the container to an older rev in the terraform deployment, if not)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves to a newer garm and garm-provider-azure revision that has been tested and includes support for gallery images on Azure. This revision uses "log/slog" so depends on being built with go 1.21.
Since the go 1.21 build container defaults to being bookworm based, specify that explicitly and use a matching bookworm debian base image for the final container.