Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Revert "config: Remove kata-qemu-se" #301

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Dec 12, 2023

This reverts commit bfba38f. This will fix a test failure at http://jenkins.katacontainers.io/job/confidential-containers-operator-main-ubuntu-20.04-s390x-SE-daily/

Fixes: #300

Signed-off-by: Hyounggyu Choi [email protected]

@stevenhorsman
Copy link
Member

@BbolroC - I think you might want to revert 63fa8b0 too?

@BbolroC
Copy link
Member Author

BbolroC commented Dec 12, 2023

@BbolroC - I think you might want to revert 63fa8b0 too?

Oh, yes. I missed it. Thanks for pointing it out.

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@stevenhorsman
Copy link
Member

/test

@stevenhorsman
Copy link
Member

@BbolroC - DCO sign-off failing on the 2nd commit

This reverts commit 63fa8b0.

Signed-off-by: Hyounggyu Choi <[email protected]>
@BbolroC BbolroC force-pushed the reintroduce-kata-qemu-se-runtime branch from 82561c3 to 1925ee5 Compare December 12, 2023 11:07
@stevenhorsman
Copy link
Member

/test

@BbolroC
Copy link
Member Author

BbolroC commented Dec 12, 2023

I am working on fixing the CI failure on s390x.

@BbolroC
Copy link
Member Author

BbolroC commented Dec 12, 2023

@stevenhorsman It looks the check tests-e2e-ubuntu-20.04-x86_64-containerd_kata-clh has been never fetched by Jenkins. I've checked the corresponding job http://jenkins.katacontainers.io/view/all/job/confidential-containers-operator-main-ubuntu-20.04-x86_64-containerd_kata-clh-PR/ was disabled yesterday. Why don't we take it out of the list?

Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @BbolroC !

@stevenhorsman stevenhorsman merged commit 407d47e into confidential-containers:main Dec 12, 2023
9 checks passed
@BbolroC BbolroC deleted the reintroduce-kata-qemu-se-runtime branch December 12, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-introduce the runtime kata-qemu-se
3 participants