do-not-merge: Test with the pending PR from kata containers #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's start properly setting a specific snapshotter per runtime handler configured for containerd. This work depends on a work done on the Kata Containers side to better support setting snapshotters per runtime handler. The PR from the Kata Containers side is: kata-containers/kata-containers#8655. Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
force-pushed
the
topic/controller-properly-set-snapshotter-per-runtime-handler-with-pending-kata-pr
branch
from
0c97cfa to
e489abc
Compare
This PR has been opened in order to test the changes needed for configuring containerd snapshotters per runtime handlers, and depends on a PR that's not yet merged on Kata Containers: kata-containers/kata-containers#8733 Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
force-pushed
the
topic/controller-properly-set-snapshotter-per-runtime-handler-with-pending-kata-pr
branch
from
e489abc to
b954ef4
Compare
|
I'm closing this one as the Kata Containers counterpart has been merged and the tests are passing in the original operator PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been opened in order to test the changes needed for
configuring containerd snapshotters per runtime handlers, and depends on
a PR that's not yet merged on Kata Containers:
kata-containers/kata-containers#8733