-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Deploy local ccruntime for s390x #485
test: Deploy local ccruntime for s390x #485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've checked the following to ensure that kustomize is installed: operator/tests/e2e/ansible/install_test_deps.yaml Lines 56 to 67 in fc492f9
I will update the PR to remove |
`quay.io/confidential-containers/reqs-payload` has been used for ccruntime for s390x. Let's use a local image for deployment. Signed-off-by: Hyounggyu Choi <[email protected]>
fe58643
to
36c6774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @BbolroC!
Well the 20.04 test is failing with the disk pressure thing. We tried cherry-picking something onto #483 to fix that, but that PR is still failing and this PR doesn't have the change. |
FYI: this patch works on s390x on top of the latest 10 commits (https://github.com/BbolroC/cc-operator/commits/refs/heads/install-debug/) on #483: https://github.com/BbolroC/cc-operator/actions/runs/12925399294/job/36046275940 |
I'm closing this because #483 has cherry-picked this and the CI has passed. Thanks. |
quay.io/confidential-containers/reqs-payload
has been used for ccruntime for s390x becauseconfig/sample/default/kustomization.yaml
is patched. This is only valid for x86_64, but s390x.It should be
config/sample/${ccruntime_overlay}/kustomization.yaml
. Let's use a local image for the platform.Signed-off-by: Hyounggyu Choi [email protected]