Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move] td-shim: Migrate staging branch td-shim to main branch #150

Closed
wants to merge 3 commits into from

Conversation

haowqs
Copy link
Contributor

@haowqs haowqs commented Mar 16, 2022

Signed-off-by: haowx <weix.hao.intel.com>

@jyao1
Copy link
Member

jyao1 commented Mar 17, 2022

@jiangliu , do you want to hold this before we resolve #73 ?

@jiangliu
Copy link
Member

@jiangliu , do you want to hold this before we resolve #73 ?

This PR is too big, and hard to review. It would be better to split into smaller PRs.

@@ -0,0 +1,7 @@
*~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to maintain a ".gitignore" file at the top level instead of multiple files in subdirectories..

@haowqs haowqs force-pushed the merge-td-shim branch 2 times, most recently from 314d1c6 to 1edfa3b Compare March 22, 2022 00:58
@jiangliu
Copy link
Member

This PR is too big to review, it would help to submit the three commits as three dedicated PRs.

@haowqs haowqs closed this Mar 22, 2022
@haowqs haowqs deleted the merge-td-shim branch April 8, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants