Added finalizer to kbsConfig CRD during creation #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpradipt
reviewed
May 23, 2024
| @@ -294,6 +295,10 @@ func (r *KbsConfigReconciler) deployOrUpdateKbsDeployment(ctx context.Context) e | |||
| } | |||
|
|
|||
| // Add the kbsFinalizer to the KbsConfig if it doesn't already exist | |||
| return r.addKbsConfigFinalizer(ctx) | |||
There was a problem hiding this comment.
The finalizer needs to be added only during the creation. So this can be removed.
bpradipt
reviewed
May 23, 2024
| @@ -275,7 +275,8 @@ func (r *KbsConfigReconciler) deployOrUpdateKbsDeployment(ctx context.Context) e | |||
| } else { | |||
| // Deployment created successfully | |||
| r.log.Info("Created a new deployment", "Deployment.Namespace", r.namespace, "Deployment.Name", KbsDeploymentName) | |||
| return nil | |||
| // Add the kbsFinalizer to the KbsConfig if it doesn't already exist | |||
| return r.addKbsConfigFinalizer(ctx) | |||
There was a problem hiding this comment.
Good catch. ..This was missing
Signed-off-by: Leonardo Milleri <[email protected]>
lmilleri
changed the title
lmilleri
pushed a commit
to lmilleri/trustee-operator
that referenced
this pull request
Aug 6, 2024
…4-my-rebase Revert "Rebase upstream 26-jul"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure the finalizer is added to the KbsResource at creation time