Add support for TDX specific configuration #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Milleri <[email protected]>
bpradipt
reviewed
Jun 28, 2024
api/v1alpha1/kbsconfig_types.go
Outdated
| @@ -76,6 +76,9 @@ type KbsConfigSpec struct { | |||
|
|
|||
| // kbsResourcePolicyConfigMapName is the name of the configmap that contains the Resource Policy | |||
| KbsResourcePolicyConfigMapName string `json:"kbsResourcePolicyConfigMapName,omitempty"` | |||
|
|
|||
| // kbsTdxConfigMapName is the name of the configmap that contains the TDX specific config | |||
| KbsTdxConfigMapName string `json:"kbsTdxConfigMapName,omitempty"` | |||
There was a problem hiding this comment.
Should we create a separate struct for TDX config? In case there are other configs that might be needed going forward
lmilleri
force-pushed
the
tdx-config
branch
3 times, most recently
from
a9ce140 to
87fa8ec
Compare
bpradipt
reviewed
Jul 2, 2024
README.md
Outdated
| KbsServiceType corev1.ServiceType `json:"kbsServiceType,omitempty"` | ||
|
|
||
| // KbsDeploymentType is the type of KBS deployment | ||
| // It can assume one of the following values: | ||
| // It can assume one of the fREADME.mdollowing values: |
bpradipt
reviewed
Jul 2, 2024
README.md
Outdated
|
|
||
| // TdxConfigSpec defines the desired state for TDX configuration | ||
| type TdxConfigSpec struct { | ||
| // kbsTdxConfigMapName is the name of the configmap that mounts the sgx_default_qcnl.conf |
There was a problem hiding this comment.
Suggested change
| // kbsTdxConfigMapName is the name of the configmap that mounts the sgx_default_qcnl.conf | |
| kbsTdxConfigMapName is the name of the configmap containing sgx_default_qcnl.conf file |
bpradipt
reviewed
Jul 2, 2024
api/v1alpha1/kbsconfig_types.go
Outdated
| @@ -36,6 +36,13 @@ const ( | |||
| DeploymentTypeMicroservices DeploymentType = "MicroservicesDeployment" | |||
| ) | |||
|
|
|||
| // TdxConfigSpec defines the desired state for TDX configuration | |||
| type TdxConfigSpec struct { | |||
| // kbsTdxConfigMapName is the name of the configmap that mounts the sgx_default_qcnl.conf | |||
There was a problem hiding this comment.
Suggested change
| // kbsTdxConfigMapName is the name of the configmap that mounts the sgx_default_qcnl.conf | |
| kbsTdxConfigMapName is the name of the configmap containing sgx_default_qcnl.conf file |
The config file /etc/sgx_default_qcnl.conf can be overriden by creating the correspondent config map Signed-off-by: Leonardo Milleri <[email protected]>
These configmaps are optional - resource-policy - TDX specific configuration Signed-off-by: Leonardo Milleri <[email protected]>
Signed-off-by: Leonardo Milleri <[email protected]>
lmilleri
pushed a commit
to lmilleri/trustee-operator
that referenced
this pull request
Sep 2, 2024
…references/main chore(deps): update konflux references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New ConfigMap added for mounting
sgx_default_qcnl.confin/etc.If you update the configmap, trustee deployment needs to be restarted.