Add option for using K8s secrets resources to KBS #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pradipta Banerjee <[email protected]>
lmilleri
reviewed
Mar 1, 2024
lmilleri
reviewed
Mar 1, 2024
|
Can you please add a short section in the README about how to add the resources? |
lmilleri
reviewed
Mar 6, 2024
KbsSecretResources entry in the CRD allows to specify the K8s secrets that needs to be made available to the KBS clients. Each secret name is mounted as follows: /opt/confidential-containers/kbs/repository/default/<secret-name-1>/key1 /opt/confidential-containers/kbs/repository/default/<secret-name-1>/key2 /opt/confidential-containers/kbs/repository/default/<secret-name-2>/key1 Signed-off-by: Pradipta Banerjee <[email protected]>
Using single method to handle volumeMount object creation under specific directories Signed-off-by: Pradipta Banerjee <[email protected]>
|
Thx, it looks good to me |
lmilleri
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows configuring K8s secrets as KBS resources