Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cgo mods in AS & RVPS #239

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

Xynnn007
Copy link
Member

This PR:

  • Deleted useless cgo mods for AS lib and RVPS lib
  • Make RVPS compilable when feature in-toto is enabled (though in-toto is not ready)
  • Fix dependency checker for go mods

@Xynnn007 Xynnn007 changed the title As remove intoto cgo Fix cgo mods in AS & RVPS Nov 24, 2023
attestation-service crate does not need in-toto dependency but opa
policy. RVPS needs in-toto dependency but OPA crate.

This commit delete useless dep and tidy the go mod dependencies.

Signed-off-by: Xynnn007 <[email protected]>
Before this commit in-toto feature cannot be built successfully.
Although in-toto feature for RVPS is still not ready, it is needed to
make the code to be compilable.

Signed-off-by: Xynnn007 <[email protected]>
After moving cgo parts of RVPS from AS, we do not have a go mod
dependencybot checker configured for that.

Signed-off-by: Xynnn007 <[email protected]>
@Xynnn007 Xynnn007 force-pushed the as-remove-intoto-cgo branch from e186e2f to 7c6356c Compare November 24, 2023 12:12
@Xynnn007 Xynnn007 marked this pull request as ready for review November 24, 2023 12:23
@Xynnn007 Xynnn007 requested a review from sameo as a code owner November 24, 2023 12:23
Copy link
Member

@jialez0 jialez0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xynnn007 Xynnn007 merged commit 93ea757 into confidential-containers:main Nov 28, 2023
6 checks passed
@Xynnn007 Xynnn007 deleted the as-remove-intoto-cgo branch November 28, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants