Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Verifier: Update Evidence format #243

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

jialez0
Copy link
Member

@jialez0 jialez0 commented Nov 28, 2023

  1. Remove unnecessary Base64 encoding from the Evidence structure and replace it with native structure content. This is because in the parameters of the AS top-level API, we assume that Evidence has already undergone Base64 encoding once, and the structure here serves as an internal interface parameter, so there is no need to repeat Base64 encoding.

  2. Added the Serial number field in the Evidence structure, serial number is to identify the HYGON chip ID. This field improves the completeness of CSV evidence, allowing for different release logic to be set for different HYGON chips when setting AS policies. This modification comes from the needs of scene users.

  3. Added the content of report data in the parsed Claims.

cc @Xynnn007 @BaoshunFang

Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialez0 jialez0 merged commit 435eddd into confidential-containers:main Nov 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants